[WIP] No longer store payload in States

[kbrock]

Overview

We use Payload#payload in State#initialize, but then do not use it again.

This PR still passes payload to initialize, but no longer stores it in an instance variable.

Before

I had kept @payload around to make debugging easier, but in truth, I have never used it to debug.

After

We no longer store State#payload.

We do need Workflow#payload to validate the State#Next values in State#initalize.
If we store/pass Workflow#payload["State"].keys into State#initialize, then this can be dropped.

We do need Path#payload, but this is not a payload but rather a path location.

WIP

This is valid, it is ready, and I like it.
Leaving as WIP to mark it as not a priority.

[agrare]

@kbrock why remove it though?

[agrare]

If the argument is that anything in @payload is duplicated by other ivars I get it, but the fact that we have to pass it in to other methods seems to be contrary to that

[kbrock]

we only pass at initialization time.
After that, we do not use it.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[kbrock]

update:

• rebased
• no longer pass payload to Choice methods.

[miq-bot]

Checked commit kbrock@dd669f1 with ruby 3.1.5, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
8 files checked, 0 offenses detected
Everything looks fine. 👍

[kbrock]

Why remove @payload though?

I have a structure in mind:

• initialize and friends parse the payload into data and actions.
• run uses that parsed data to act.

If we completely parse at initialization, then we detect most errors upfront and let the user know there are issues.
Alternatively, if we parse at runtime, then we detect the errors at a future time, and if the user is not monitoring workflow.log, then possibly missed that an error even ocured.

So not having payload around means we parse everything upfront.

---

But Yea, "why remove this?" - this is the reason for keeping this as a WIP from the start.

[kbrock]

Giving up for now