-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel state #291
Merged
Merged
Parallel state #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5c48568
to
7d1de74
Compare
2d5b0c8
to
ecce6cf
Compare
kbrock
reviewed
Oct 28, 2024
spec/shared/workflow_base_shared.rb
Outdated
@@ -0,0 +1,25 @@ | |||
shared_examples_for "WorkflowBase" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please rename file to shared/workflow_base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 done
ecce6cf
to
c1b5e61
Compare
agrare
added a commit
that referenced
this pull request
Oct 28, 2024
Added - Add WorkflowBase base class for Workflow (#279) - Add tool for using the aws stepfunctions simulator (#244) - Implement Map state (#184) - Add Map State Tolerated Failure (#282) - Run Map iterations in parallel up to MaxConcurrency (#283) - Implement Parallel State (#291) Changed - More granular compare_key and determine path at initialization time (#274) - For Choice validation, use instance variables and not payload (#277) - Return ExceedToleratedFailureThreshold if ToleratedFailureCount/Percentage is present (#285) Fixed - Fix case on log messages (#280) - Handle either ToleratedFailureCount or ToleratedFailurePercentage (#284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows a similar pattern as Map, there are child workflows that are run by a single thread so multiple Task states can be running at once but no race condition on the Context hash as all updates are made by a single thread
Fixes #287