Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Mesh: WC14to60kmL60E3SMv2r03 #628

Merged
merged 6 commits into from
Aug 17, 2020
Merged

New Mesh: WC14to60kmL60E3SMv2r03 #628

merged 6 commits into from
Aug 17, 2020

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Jul 10, 2020 •
edited
Loading

Design discussion Water Cycle mesh, 14km high resolution region:

MPAS North America and Arctic Focused Water Cycle mesh for E3SM version 2, with a focused 14-km resolution around North America and 60 vertical levels

This iteration of the WC14 mesh is with shipping tracks (MPAS-Dev/geometric_features#145) and the Foxe Basin Throughflow (MPAS-Dev/geometric_features#146) open in the Arctic.

@xylar xylar requested a review from vanroekel July 10, 2020 20:10
@xylar
Copy link
Collaborator Author

xylar commented Jul 10, 2020 •
edited
Loading

@vanroekel, would you set up the review process for this mesh on Confluence, as you have for previous revisions? Please select reviewers as you think is appropriate.

@xylar
Copy link
Collaborator Author

xylar commented Jul 10, 2020

I am working on spinning this up on LANL IC at:

/lustre/scratch4/turquoise/xylar/spin_up_WC14to60kmL60E3SMv2r03/ocean/global_ocean/WC14

I will post some plots once it has finished initialization and will also post here when spin-up is complete.

@proteanplanet
Copy link

@xylar I'll run some visual QC over the mesh when ready, and post it here.

@vanroekel
Copy link
Contributor

@xylar the confluence page is here -- https://acme-climate.atlassian.net/wiki/spaces/EWCG/pages/1492910110/WC14to60kmL60E3SMv2r03

Thanks for making the PR. I'll dig in once @proteanplanet has a chance to make some QC figures (no rush, we are running WC14r02 with ne30 now)

@vanroekel
Copy link
Contributor

also thanks for making 60 layer the default!

@xylar
Copy link
Collaborator Author

xylar commented Jul 11, 2020

Distribution of Resolution

This is the same as in #584

cellWidthGlobal
mesh_construction

@proteanplanet, the mesh is available at this location:

/lustre/scratch4/turquoise/xylar/spin_up_WC14to60kmL60E3SMv2r03/ocean/global_ocean/WC14/init/initial_state/initial_state.nc

Please proceed with your quality-control plots. The spin-up is still waiting in the queue

@proteanplanet
Copy link

Global Scale Sectors

WC14r03_sector_1

WC14r03_sector_2

WC14r03_sector_3

WC14r03_sector_4

WC14r03_sector_5

WC14r03_sector_6

@proteanplanet
Copy link

Regional Zooms

WC14r03_zoom_1

WC14r03_zoom_2

WC14r03_zoom_3

WC14r03_zoom_4

WC14r03_zoom_5

WC14r03_zoom_6

WC14r03_zoom_7

WC14r03_zoom_8

WC14r03_zoom_9

WC14r03_zoom_10

WC14r03_zoom_11

WC14r03_zoom_12

WC14r03_zoom_13

WC14r03_zoom_14

WC14r03_zoom_15

WC14r03_zoom_16

WC14r03_zoom_17

WC14r03_zoom_18

WC14r03_zoom_19

WC14r03_zoom_20

WC14r03_zoom_21

WC14r03_zoom_22

WC14r03_zoom_23

WC14r03_zoom_24

WC14r03_zoom_25

WC14r03_zoom_26

WC14r03_zoom_27

WC14r03_zoom_28

WC14r03_zoom_29

WC14r03_zoom_30

WC14r03_zoom_31

WC14r03_zoom_32

WC14r03_zoom_33

WC14r03_zoom_34

WC14r03_zoom_35

WC14r03_zoom_36

WC14r03_zoom_37

WC14r03_zoom_38

WC14r03_zoom_39

WC14r03_zoom_40

WC14r03_zoom_41

WC14r03_zoom_42

@vanroekel
Copy link
Contributor

@milenaveneziani @lconlon @qingli411 @proteanplanet please provide your thoughts on this mesh. Once approved we will plan on running a coupled simulation for potential finalizing into WC v2 of E3SM

lconlon
lconlon approved these changes Jul 13, 2020
View reviewed changes
Copy link

@lconlon lconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the North Atlantic looks great. Looking forward to seeing the output.

@proteanplanet
Copy link

Review and Points to Consider

  • The Arctic and Antarctic are just about perfect.
  • Delaware Bay, Chesapeake Bay, Gulf of Mexico and Caribbean are also as perfect as they can be at this resolution.
  • Indonesian Throughflow has a sufficient number of channels at 2 cells wide or more
  • Items that I think just need to be accepted at this resolution: Puget Sound and Strait of Gibraltar.

I'll post bathymetric charts in the coming day as a point of documentation.

@xylar
Copy link
Collaborator Author

xylar commented Jul 13, 2020

@vanroekel, I ran the spin-up but it fails on the final step with:

ERROR: Stream 'restart' attempted to read non-existent file 'restarts/restart.0001-01-01_00.00.00.nc'

Based on our discussion of the r02 mesh (#584 (comment)), I had the impression you had fixed test_final_settings but maybe something didn't get committed in that PR and needs to be added here?

@xylar
Copy link
Collaborator Author

xylar commented Jul 13, 2020

The spin-up is at:

/lustre/scratch4/turquoise/xylar/spin_up_WC14to60kmL60E3SMv2r03/ocean/global_ocean/WC14/spin_up

@xylar
Copy link
Collaborator Author

xylar commented Jul 13, 2020

@vanroekel, I think I've addressed the final spin-up step, but please verify that this is also what you did last time.

@vanroekel
Copy link
Contributor

@xylar thanks, the changes are consistent with what I did and you are exactly right. I had uncommitted changes that never propagated into the last PR. Thanks for the fix!

milenaveneziani
milenaveneziani approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great (southern Italy looks awful, but that is OK ;)).

qingli411
qingli411 approved these changes Jul 13, 2020
View reviewed changes
Copy link

@qingli411 qingli411 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me as well!

@xylar xylar force-pushed the ocean/compass_wc14r03 branch from ef450e8 to 31c5379 Compare July 14, 2020 08:31
@xylar
Copy link
Collaborator Author

xylar commented Jul 14, 2020 •
edited
Loading

@vanroekel, my changes didn't work in the test I ran. I got confused because restarting from day 07 is, of course, only 6 days into the simulation.

I am now writing restarts every 6 days (the maximum if restarting from day 6) and running for 24 more days to 30 days total.

I've pointed the E3SM-coupling to the final output on day 31.

@xylar xylar force-pushed the ocean/compass_wc14r03 branch 2 times, most recently from 50428cf to 3bf93bc Compare July 14, 2020 09:59
xylar added 3 commits August 9, 2020 02:40
@xylar
Add PR number to metadata
f4423ff
@xylar
Switch 60 layers to be the default vertical res
40fbc08
@xylar
Update test_final_settings to run correctly
23b073b 
The restart interval and run duration were not consistent with
other spin-up configurations or the E3SM-coupling step.

The final restart file expected by E3SM-coupling was not an even
multiple of the restart interval so that also needed to change.
@xylar xylar force-pushed the ocean/compass_wc14r03 branch from 3bf93bc to 23b073b Compare August 9, 2020 08:54
@vanroekel
Copy link
Contributor

@xylar I would just want to make sure @mark-petersen is okay with merging, otherwise given others approvals I think this is ready.

@mark-petersen
Copy link
Contributor

Sorry for the delay. Testing now. @vanroekel please approve if you feel this is ready.

vanroekel
vanroekel approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@vanroekel vanroekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved on visual inspection

@mark-petersen mark-petersen merged commit aaaa69e into MPAS-Dev:ocean/develop Aug 17, 2020
mark-petersen added a commit that referenced this pull request Aug 17, 2020
@mark-petersen
Merge branch 'ocean/develop' into e3sm/develop
fe4d587 
* ocean/develop:
  Move load_compass_env.sh to the ocean dir #618
  Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC #653
  Fix path to docs in Travis CI #644
  New Mesh: WC14to60kmL60E3SMv2r03 #628
This was referenced Aug 17, 2020
Merged
Merged
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Aug 18, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_200817' into next (PR #3776)
72e0ed9 
Update MPAS-Source: COMPASS and Documentation files

This PRi brings in a new mpas-source submdoule with changes only to the ocean
core. It updates files unrelated to the E3SM forward model, including:
* Move load_compass_env.sh to the ocean dir  (MPAS-Dev/MPAS-Model#618);
* Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC
  (MPAS-Dev/MPAS-Model#653);
* Fix path to docs in Travis CI  (MPAS-Dev/MPAS-Model#644);
* atmosphere core init changes  (MPAS-Dev/MPAS-Model#637);
* New Mesh: WC14to60kmL60E3SMv2r03  (MPAS-Dev/MPAS-Model#628);
* Fix ISOMIP+ viz scripts  (MPAS-Dev/MPAS-Model#642);
* Add support for custom critical passages and land blockages
  (MPAS-Dev/MPAS-Model#586); and
* New Mesh: WC12to60kmL60E3SMv2r01  (MPAS-Dev/MPAS-Model#555)

[BFB]
jonbob added a commit to E3SM-Project/E3SM that referenced this pull request Aug 19, 2020
@jonbob
Merge branch 'mark-petersen/update_mpas_200817' (PR #3776)
b84ab6c 
Update MPAS-Source: COMPASS and Documentation files

This PR brings in a new mpas-source submdoule with changes only to the ocean
core. It updates files unrelated to the E3SM forward model, including:
* Move load_compass_env.sh to the ocean dir  (MPAS-Dev/MPAS-Model#618);
* Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC
  (MPAS-Dev/MPAS-Model#653);
* Fix path to docs in Travis CI  (MPAS-Dev/MPAS-Model#644);
* atmosphere core init changes  (MPAS-Dev/MPAS-Model#637);
* New Mesh: WC14to60kmL60E3SMv2r03  (MPAS-Dev/MPAS-Model#628);
* Fix ISOMIP+ viz scripts  (MPAS-Dev/MPAS-Model#642);
* Add support for custom critical passages and land blockages
  (MPAS-Dev/MPAS-Model#586); and
* New Mesh: WC12to60kmL60E3SMv2r01  (MPAS-Dev/MPAS-Model#555)

[BFB]
@xylar xylar deleted the ocean/compass_wc14r03 branch August 21, 2020 11:42
caozd999 pushed a commit to caozd999/MPAS-Model that referenced this pull request Jan 14, 2021
@mark-petersen
Merge PR MPAS-Dev#628 'xylar/ocean/compass_wc14r03' into ocean/develop
e9079a2 
New Mesh: WC14to60kmL60E3SMv2r03 MPAS-Dev#628

Design discussion Water Cycle mesh, 14km high resolution region:

MPAS North America and Arctic Focused Water Cycle mesh for E3SM version
2, with a focused 14-km resolution around North America and 60 vertical
levels

This iteration of the WC14 mesh is with shipping tracks
(MPAS-Dev/geometric_features#145) and the Foxe Basin Throughflow
(MPAS-Dev/geometric_features#146) open in the Arctic.
@vanroekel vanroekel mentioned this pull request Mar 17, 2021
Merged
@mark-petersen
Copy link
Contributor

PS: A mesh generation timing test took 18:14 on Chrysalis on one node.

@mark-petersen mark-petersen mentioned this pull request Feb 3, 2022
Closed
This was referenced Sep 20, 2023
Closed
Closed
@xylar xylar mentioned this pull request Sep 28, 2023
Closed
1 task
This was referenced Feb 21, 2024
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lconlon lconlon lconlon approved these changes

@proteanplanet proteanplanet proteanplanet approved these changes

@vanroekel vanroekel vanroekel approved these changes

@qingli411 qingli411 qingli411 approved these changes

@milenaveneziani milenaveneziani milenaveneziani approved these changes

Assignees

@mark-petersen mark-petersen

Labels
COMPASS mesh Ocean
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@xylar @proteanplanet @vanroekel @mark-petersen @milenaveneziani @qingli411 @lconlon @matthewhoffman