-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix path to docs in Travis CI #644
Conversation
Replace space (not backslash) with underscore in the path. Documentation for "latest coastal" and "lastest ocean" is being placed in a directory that is not very convenient to reference.
@mark-petersen and @sbrus89, I noticed that recent merges put documentation here: I made a small mistake and the space should have been replaced with an underscore. I'm mostly asking for your review to confirm that you think this change will fix the problem, since it's not very easy to test. |
This fix won't propagate to ocean/develop or ocean/coastal for awhile so we'll just have to live with the bad path for awhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar, since this is only a single character change and only for travis_ci, I'm happy to merge it in today, then develop into ocean/develop, and we can see if it works. From a web search, I see %20
in a web address is a space. I don't understand where the space comes from originally, but it sure looks like your correction here should put in a space. I see that using an actual space on a web link:
http://mpas-dev.github.io/MPAS-Model/latest%20coastal/
does work (i.e. replace %20 above with space on your browser)
@mgduda @matthewhoffman @akturner: FYI, for PRs to develop that only involve Travis CI and documentation, I will not ask for your approval, as we are still getting the kinks out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar, this looks good to me!
@mark-petersen, the space comes from this file: |
Update MPAS-Source: COMPASS and Documentation files This PRi brings in a new mpas-source submdoule with changes only to the ocean core. It updates files unrelated to the E3SM forward model, including: * Move load_compass_env.sh to the ocean dir (MPAS-Dev/MPAS-Model#618); * Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC (MPAS-Dev/MPAS-Model#653); * Fix path to docs in Travis CI (MPAS-Dev/MPAS-Model#644); * atmosphere core init changes (MPAS-Dev/MPAS-Model#637); * New Mesh: WC14to60kmL60E3SMv2r03 (MPAS-Dev/MPAS-Model#628); * Fix ISOMIP+ viz scripts (MPAS-Dev/MPAS-Model#642); * Add support for custom critical passages and land blockages (MPAS-Dev/MPAS-Model#586); and * New Mesh: WC12to60kmL60E3SMv2r01 (MPAS-Dev/MPAS-Model#555) [BFB]
Update MPAS-Source: COMPASS and Documentation files This PR brings in a new mpas-source submdoule with changes only to the ocean core. It updates files unrelated to the E3SM forward model, including: * Move load_compass_env.sh to the ocean dir (MPAS-Dev/MPAS-Model#618); * Update ISOMIP+ docs, including tutorial for Ocean0 on LANL IC (MPAS-Dev/MPAS-Model#653); * Fix path to docs in Travis CI (MPAS-Dev/MPAS-Model#644); * atmosphere core init changes (MPAS-Dev/MPAS-Model#637); * New Mesh: WC14to60kmL60E3SMv2r03 (MPAS-Dev/MPAS-Model#628); * Fix ISOMIP+ viz scripts (MPAS-Dev/MPAS-Model#642); * Add support for custom critical passages and land blockages (MPAS-Dev/MPAS-Model#586); and * New Mesh: WC12to60kmL60E3SMv2r01 (MPAS-Dev/MPAS-Model#555) [BFB]
Replace space (not backslash) with underscore in the path.
Documentation for "latest coastal" and "lastest ocean" is being
placed in a directory that is not very convenient to reference.