-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Mesh: WCAtl12to45E2r4 #60
Conversation
@vanroekel, here is the very first draft: The transition in resolution in the Arctic needs to change. My feeling is that the Bering Straight is probably where the transition should happen and the Arctic needs to be part of the RRS30to10 region, but let me know if you want to try something else. A few more questions:
|
[mesh] | ||
short_name = ${prefix}${min_res}to${max_res}E${e3sm_version}r${mesh_version} | ||
long_name = ${prefix}${min_res}to${max_res}kmL${levels}E3SMv${e3sm_version}r${mesh_version} | ||
prefix = WC_SO_Atl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We likely want a different name. Just WC
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking WC_Atl would be a reasonable choice. We may want Atl as just having the resolution min/max could be misleading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think WCAtl (without any underscores) would be better. I think I recall there were problems with punctuation in mesh names (possibly including underscores).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WCAtl sounds good to me.
ocean/global_ocean/WC_SO_Atl10/files_for_e3sm/config_files_for_e3sm.ini
Outdated
Show resolved
Hide resolved
ocean/global_ocean/WC_SO_Atl10/files_for_e3sm/config_files_for_e3sm.ini
Outdated
Show resolved
Hide resolved
ocean/global_ocean/WC_SO_Atl10/files_for_e3sm/config_files_for_e3sm.ini
Outdated
Show resolved
Hide resolved
4b8119f
to
387d5b6
Compare
<case name="prep_spin_up1"> | ||
<step executable="./run.py" quiet="true" pre_message=" * Running prep_spin_up1" post_message=" - Complete"/> | ||
</case> | ||
<case name="prep_spin_up2"> | ||
<step executable="./run.py" quiet="true" pre_message=" * Running prep_spin_up2" post_message=" - Complete"/> | ||
</case> | ||
<case name="prep_spin_up3"> | ||
<step executable="./run.py" quiet="true" pre_message=" * Running prep_spin_up3" post_message=" - Complete"/> | ||
</case> | ||
<case name="simulation"> | ||
<step executable="./run.py" quiet="true" pre_message=" * Running simulation" post_message=" - Complete"/> | ||
</case> | ||
<validation> | ||
<compare_fields file1="simulation/output.nc"> | ||
<template file="prognostic_comparison.xml" path_base="script_core_dir" path="templates/validations"/> | ||
</compare_fields> | ||
</validation> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update based on @vanroekel and @lconlon's new strategy.
<option name="config_global_ocean_topography_smooth_iterations">10</option> | ||
<option name="config_global_ocean_topography_smooth_weight">0.92</option> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure we want topography smoothing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My thinking is we probably do, but for consistency, I'd like to stick with whatever we did for the WC14 mesh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll check on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WC14 didn't include any smoothing, but the SORRM mesh did. For now, I have taken out smoothing to be consistent with WC14, but let me know if you'd prefer to be consistent with SORRM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After pondering this a bit more, I'd say we put our best configuration forward and I think that would include smoothing. Let's switch to consistent with SORRM. Sorry for changing again.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, that's why I asked.
Thanks for starting this so quickly @xylar! It is looking pretty great already. A couple replies
|
@vanroekel, that all sounds good. I'll make revisions and start a new build in Anvil soon. |
No worries, thanks for asking the questions and the review! |
@vanroekel, culling this mesh is going to take many, many hours. I have a 4-hour job just for this on Anvil but I think it's going to time out. I'm going to put in a 10-hour job now to make sure it's done by the time I get up tomorrow. |
@vanroekel, one more update.
|
@xylar do you have the number of horizontal cells (or do you need the culled mesh for that)? For reference, the RRS30to10v3 has 1,445,361. |
Take out topography smoothing
The new version will show up here. I just submitted an 8-hour job to create it. Fingers crossed:
|
Yes, I need the culled mesh for that but I have it:
|
For comparison, SORRMr4 has:
and my proposed SORRMr5 mesh would have:
|
If anyone wants to just look at the culled mesh, it's at:
The same thing should eventually end up in the newer directory I listed above:
|
This is great progress. Thanks @xylar! I'm happy to see this come in around 2x WC14. Hopefully this helps WC issues! |
@vanroekel, the mesh and initial condition are now available on Anvil. I had to fix the namelist options related to the topography (because we are using the GEBCO/BedMachine topography, which has different variable names). The short Please push to this branch or make suggestions for modifying |
@xylar I've modified the spin up. WC never had a chance to switch to the new spin up, so I think it is best to do spin up as we have done but set parameters more closely aligned with target settings for E3SM, I've done so here. |
Thanks @vanroekel. I tried spinning up but we seem to be getting CFL violations within the first 10 hours. I have a meeting but will try to play with parameters in an hour or so. |
Thanks @xylar. Please let me know if you'd like any help tinkering to get this stable. Happy to jump in if it would be useful. |
It seems like it's just a time step that's too long. Should be easy to fix. |
Reducing the time step in the first stage seems to have done it. Probably overkill but I don't feel like playing around with it. I'm working on the final stage (the files for E3SM and MPAS-Analysis). |
@vanroekel, @darincomeau and @jonbob, the files are in place, as I just emailed you:
@vanroekel, let me know when you think this mesh revision is "finalized" and I'll merge this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on visual inspection, figures posted to the PR and testing from @darincomeau
sorry for the letting this one slip @xylar I think we can finalize this and integrate to compass. Thanks again for the quick and great work! |
Thanks @vanroekel. Definitely no rush but it's also good to get this merged so we don't forget. |
Full description to come once we iterate a bit...