[pull] canary from vercel:canary #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
### What? Update `@swc/helpers` to `v0.5.1`. ### Why? Webpack merges `@swc/[email protected]` and `@swc/[email protected]`, due to `resolve.alias` config in https://github.com/vercel/next.js/blob/2f6ff0dab330b854c43a1773be2fe739c3582419/packages/next/src/build/webpack-config.ts#L1070-L1072 To workaround it, `@swc/[email protected]` reexports from entries just like `v0.4`. ### How? Closes WEB-948 Fixes #48593
### What? Mux reported that their website does not scroll to hash when clicking a search result. Found it's related to `server-patch` triggering and overriding the hashFragment. That should be preserved similarly to `apply`. ### How? handleMutable had a default of `null` instead of using the existing value. It should use the existing value.
Improve array resolving in metadata, remove ts comments for errors
) This is currently an overhead, that we check a module's layer (`mod.buildInfo.rsc?.type === RSC_MODULE_TYPES.client`) and put all client modules in the client reference manifest, but the manifest is only used for accessing these entry modules. So here we change the util to check if it's an client entry instead. With this change the client manifest of a test app decreased from 177 KB to 70 KB. Ref: https://github.com/vercel/next.js/blob/5b609e264f56e6e7c6e230d88ad444650b5b6ba9/packages/next/src/build/analysis/get-page-static-info.ts#L50-L64
Part of #47759 (which had been reverted twice so here we only land a part of the change), relates to NEXT-926. Thanks to #48506 we can soon switch between these two channels during runtime. Also fixes a problem of `renderKind` (only revealed after upgrading React), it should be also based on the `match` kind.
### What? Fix the query for app dir ### Why? it's not correct in app dir
It makes more sense to use the `FormData` from `@edge-runtime/primitives` to ensure the version and implementation are aligned, and avoid importing extra modules (as we always import the Edge Runtime).
This PR adds an `AsyncLocalStorage` wrapper to the action handler, so underlying function calls can tell if it's running in that.
…48799) Fixes the ``` TypeError: Cannot read properties of undefined (reading 'strict') at writeConfigurationDefaults ``` error. Co-authored-by: JJ Kasper <[email protected]>
…ltiple dev servers running at once (#48857) We were adding filling in our cleanup function after we started our server. So If we restarted while the server was starting, we would fire an empty cleanup function which would lead to the server not being cleaned up (once it starts). The only slight issue is that it won't watch for changes while cleaning up the previous run (waiting for the server from the last run to start and finish). fix NEXT-1052
## What? When investigating #48852 I found that when there's a `segmentPath` set in the `focusAndScrollRef` it would compare that entire path with the `segmentPath` of the layout-router. This logic works in cases where the entire page is rendered but doesn't take into account cases where for example a suspense boundary is triggered below the common layout. Because of the order `useEffect` is run in we can already assume that if a more specific match existed it would have scrolled there. As that is not the case in e.g. #48852 it ended up opting out of scrolling entirely. In order to fix that the logic needs to be different, it needs to check if the layout-router's `segmentPath` matches, if it matches every level then we can apply scrolling in that layout-router. ## How? Implemented the opposite of the current logic, running `.every` on the layout-router segmentPath instead of on the router provided segmentPath. Fixes #48852 Fixes NEXT-1053 Related PR #48862 <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
Similar to #47922 but based off the latest server implementation and #48626: > This PR implements the MutableRequestCookies instance for cookies() based on the current async context, so we can allow setting cookies in certain places such as Server Functions and Route handlers. Note that to support Route Handlers, we need to also implement the logic of merging Response's Set-Cookie header and the cookies() mutations, hence it's not included in this PR. > > fix [NEXT-942](https://linear.app/vercel/issue/NEXT-942) This PR also adds the same support for Custom Routes. cc @styfle. fix NEXT-942, fix NEXT-941.
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? This PR is necessary changes to apply vercel/turborepo#4662. Need turbopack bump to make CI pass. --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
### What? Added missing `that` to documentation for getStaticProps ### Why? This change fixes grammar. ### How? Updated the text.
This PR make possible to use WebSocket in an Edge Function 🙂
### What? missing aliases for app dir functionality ### Why? ### How?
### What? Updates Deploy button URLs for all listed examples here: https://github.com/vercel/next.js/tree/canary/examples ### Why? The Deploy URLs are currently broken and result in a failed clone attempt on Vercel. ### How? The URLs have been changed from https://vercel.com/new/git/external?… to -> https://vercel.com/new/clone?… (Last updated [here](8eaabe2) in 2021)
This PR changes `mutableCookies` from `RequestCookies` to a `ResponseCookies` instance, and it now accepts extra options for each cookie. Take a look at the tests for more details. cc @styfle --------- Co-authored-by: Steven <[email protected]>
### What For dynamic routes you might have different sitemap for different params * Unloack using `sitemap.[ext]` in your app everywhere * Support `generateSitemaps()` to create multiple sitemaps at the same time ### How * Change the metadata regex to allow use sitemap in every routes * Similar approach to `generateImageMetadata`, we make `sitemap.js` under dynamic routes to a catch all routes, and it can have multiple routes Closes NEXT-1054
### What? WEB-953. This PR moves, bubbles up unsupported package warning from turbopack to next-core using resolve plugin. Featurewise it behaves same, however removes turbopack aware specific next.js package (`@vercel/og`) internally.
### What? * vercel/turborepo#4700 <!-- Tobias Koppers - update deps --> * vercel/turborepo#4706 <!-- Tobias Koppers - make library code less verbose in stack traces --> * vercel/turborepo#4705 <!-- Tobias Koppers - improve error handling in update stream --> * vercel/turborepo#4667 <!-- Caleb Webber - remove box_syntax --> * vercel/turborepo#4714 <!-- Tobias Koppers - chunk hash need to include availability root --> * vercel/turborepo#4709 <!-- Alex Kirszenberg - Allow the dev server socket to be reused immediately --> * vercel/turborepo#4716 <!-- Tobias Koppers - errors lead to consistent exit code in issue detail -->
### Why Default font file of `@vercel/og` is not loaded, because the og package is bundled by webpack and we should external it so that `fs.readFileSync` is bundled and manged that can't be traced by nft. ### How This PR externals `@vercel/og` so that they don't need to be bundled and files can be properly traced Closes NEXT-1047 Fixes #48704
This should fix the `requestAsyncStorage not available` error. [Related report](https://vercel.slack.com/archives/C03S8ED1DKM/p1683553422581859).
When revalidate isn't defined in the tree at all and a fetch without cache/revalidate fields is done we are incorrectly marking the initial revalidate period with a time based value when it should be `false`. This causes pages that should be fully static to revalidate unexpectedly. x-ref: [twitter thread](https://twitter.com/diegohaz/status/1655638433795014657) x-ref: [slack thread](https://vercel.slack.com/archives/C03S8ED1DKM/p1683566860136879)
Fix the bad encoded buffer introduced in #49323
This ensures we properly strip conflicting headers from being forwarded when handling the redirect request/response in actions. x-ref: [slack thread](https://vercel.slack.com/archives/C042LHPJ1NX/p1683218335368759) Fixes: ```sh failed to get redirect response TypeError: fetch failed at Object.fetch (node:internal/deps/undici/undici:11413:11) { cause: RequestContentLengthMismatchError: Request body length does not match content-length header at write (node:internal/deps/undici/undici:9907:41) at _resume (node:internal/deps/undici/undici:9885:33) at resume (node:internal/deps/undici/undici:9787:7) at connect (node:internal/deps/undici/undici:9776:7) { code: 'UND_ERR_REQ_CONTENT_LENGTH_MISMATCH' } } ```
…#49331) This PR extends `invalid_server_react_dom_apis` with `experimental_useOptimistic` and `experimental_useFormStatus` to create early compile-time errors.
This ensures we use the proper body stream when rewriting to an external resource as currently it tries to consume an already read body stream. Fixes: #48040
fixes #47641 This adds a friendly error for loading a font error caused by the invalid `assetPrefix` setting. Current: <img width="747" alt="image" src="https://user-images.githubusercontent.com/250407/236685607-c03b6160-9e8c-4c88-80e1-714f6a140588.png"> This PR: <img width="890" alt="image" src="https://user-images.githubusercontent.com/250407/236685499-da4c3d69-0f97-458d-8709-dcc43475e0e9.png"> <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> --------- Co-authored-by: JJ Kasper <[email protected]>
Uses the choice input type instead of requiring manually typing the values.
### What? Allow overwriting the `global.crypto` property when polyfilling it. ### Why? #48941 introduced `global.crypto` polyfill. The problem is that if some library (e.g. [xksuid](https://github.com/ValeriaVG/xksuid/blob/main/src/index.node.mjs)) tries to do the same thing, it breaks as `global.crypto` is defined as non-writable[^1]. Arguably libraries should check for `global.crypto` presence before overwriting it BUT I think polyfill should match the actual implementation[^2]. ### How? Make `global.crypto` `enumerable` and `configurable`, as well as define `set` implementation[^3]. [^1]:  [^2]:  [^3]:  --------- Co-authored-by: Tim Neutkens <[email protected]>
Hey there :) I found this small issue. Replace `var` with `const` for block-scope variable declaration following the standard introduced by ES2015. <!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # -->
testing react version in pages for deployment env
…outes (#48753) Fixes: #43598 This was a tricky one to find! Not sure why more people aren't complaining about this issue, was super annoying in my use case since links had the wrong URL. ## What? This issue only occurred when basepath was defined and middleware and dynamic pages are being used. Example from the reproduction repo mentioned in the issue tagged: <img width="686" alt="Screenshot 2023-04-23 at 9 32 55 PM" src="https://user-images.githubusercontent.com/11258286/233850968-e14f6b49-858b-410e-b8f9-93c90447090a.png"> ## Why? `nextConfig` wasn't passed to `getNextPathnameInfo` function, hence the basePath wasn't removed from a intermediate variable and that trickled down to cause this issue. Added test case based on the issue reproduction repo --------- Co-authored-by: Jimmy Lai <[email protected]>
We recently ran into hydration mismatch errors on iOS, which we realised was due to iOS automatically converting what it thought were phone numbers into links. We then found this GitHub issue, #38290, and thought it would be useful to add these details to the documentation page linked from the next.js error. --- Example from the linked issue:  ## Documentation / Examples - [x] Make sure the linting passes by running `pnpm build && pnpm lint` - [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md) Co-authored-by: Tim Neutkens <[email protected]>
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### What? ### Why? ### How? Closes NEXT- Fixes # --> update React.CSSProperties type to Record --------- Co-authored-by: Parbez <[email protected]>
…tions (#49462) In Hot Reloader we use `mod.resource.replace(/\\/g, '/').includes(key)` to see if the module is the entry. However that `includes` check isn't solid. Say the entry key is `app/path/page`, these will all be matched: ``` app/path/page.js app/path/page.css app/unrelated/app/path/page/another/page.js ``` This PR fixes that and added a test case. I'm unsure if this fixes the newly reported cases in #43396. fix NEXT-1110
This PR implements initial support for `.bind` syntax for inline actions
(not top-level `"use server"` files yet). For example:
```js
export default function Page({ foo, x, y }) {
async function action(a, b, c, d) {
'use server'
console.log(a, b, c, d)
}
return <ClientComp action={action.bind(null, foo[0], foo[1], foo.x, foo[y])} />
}
```
Is now valid.
Fixes NEXT-1109.
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> ### What? closees WEB-1019. As discussed, this PR enables running a set of next.js integration tests with turbopack as blocking CI check. The tests listed as `enabled` is considered as stable, that should not fail in any case except upstream test flakyness. Current approach is simple as we have only small set of tests and does not consider it becomes a bottleneck. Adding a test under https://github.com/vercel/next.js/pull/49466/files#diff-fdc68d6039dbe36607cda253b318cd3598a09a94ccb8994f3695aa1d9e1e404bR2 will makes run with turbopack in the CI. in the future, I'll revise test suite itself so runner, or test case can mark & execute test with existing test group / scheduling.
<!-- Thanks for opening a PR! Your contribution is much appreciated. To make sure your PR is handled as smoothly as possible we request that you follow the checklist sections below. Choose the right checklist for the change(s) that you're making: ## For Contributors ### Improving Documentation or adding/fixing Examples - The "examples guidelines" are followed from our contributing doc https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md - Make sure the linting passes by running `pnpm build && pnpm lint`. See https://github.com/vercel/next.js/blob/canary/contributing/repository/linting.md ### Fixing a bug - Related issues linked using `fixes #number` - Tests added. See: https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ### Adding a feature - Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR. (A discussion must be opened, see https://github.com/vercel/next.js/discussions/new?category=ideas) - Related issues/discussions are linked using `fixes #number` - e2e tests added (https://github.com/vercel/next.js/blob/canary/contributing/core/testing.md#writing-tests-for-nextjs - Documentation added - Telemetry added. In case of a feature if it's used or not. - Errors have a helpful link attached, see https://github.com/vercel/next.js/blob/canary/contributing.md ## For Maintainers - Minimal description (aim for explaining to someone not on the team to understand the PR) - When linking to a Slack thread, you might want to share details of the conclusion - Link both the Linear (Fixes NEXT-xxx) and the GitHub issues - Add review comments if necessary to explain to the reviewer the logic behind a change ### Why? ### How? Closes NEXT- Fixes # --> #### What Part 1 for WEB-848. This PR implements initial path to enable relay compiler option in Turbopack. PR is based on approach WEB-955, that passing custom plugin transform itself instead of trying to pass down configuration into turbopack. In result, this PR requires counterpart turbopack PR at vercel/turborepo#4721. PR also refactors next-shared's transform bit, as we have grown number of custom transforms. Unfortunately there are some runtime errors with this transforms, so it is not possible to use relay actually yet. WEB-956 tracks this. (swc-project/plugins#179) --------- Co-authored-by: Tobias Koppers <[email protected]> Co-authored-by: JJ Kasper <[email protected]>
```
✕ should match query path (2857 ms)
● Middleware custom matchers basePath › should match query path
expect(received).toBe(expected) // Object.is equality
Expected: "random"
Received: ""
```
https://github.com/vercel/next.js/actions/runs/4929337370/jobs/8809028722?pr=49529#step:6:201
The `pathname` in app-render was actually "page" (e.g. `/blog/[slug]`), with special url conventions. Instead we should use actual request url as pathname. Rename previous `pathname` arg to `pagePath` for better readability Also improved the url validation
This implements experimental`compile`/`generate` commands to allow separate the compilation and static generation steps of the build. Initially this is for testing and follows same experimental rules which aren't covered by semver. Note: most changes are just spacing changes so disabling that in the diff will be helpful. x-ref: [initial thread](https://www.notion.so/vercel/bbdbba2016ed464eb5263d325fecc02f?pvs=4) x-ref: [slack thread](https://vercel.slack.com/archives/C03DQ3QFV7C/p1676591260523589?thread_ts=1676554904.334789&cid=C03DQ3QFV7C)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )