Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FixedStaticAsset and TextContentSourceAsset #4692

Merged
merged 2 commits into from
Apr 25, 2023
Merged

add FixedStaticAsset and TextContentSourceAsset #4692

merged 2 commits into from
Apr 25, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 25, 2023

Description

needed for metadata support in next.js (vercel/next.js#48823)

@sokra sokra requested a review from a team as a code owner April 25, 2023 12:52
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-cra-web 🔄 Building (Inspect) Apr 25, 2023 2:56pm
examples-designsystem-docs 🔄 Building (Inspect) Apr 25, 2023 2:56pm
examples-gatsby-web 🔄 Building (Inspect) Apr 25, 2023 2:56pm
8 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-kitchensink-blog ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-native-web ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-nonmonorepo ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-svelte-web ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-tailwind-web ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
examples-vite-web ⬜️ Ignored (Inspect) Apr 25, 2023 2:56pm
turbo-site ⬜️ Ignored (Inspect) Visit Preview Apr 25, 2023 2:56pm

@github-actions
Copy link
Contributor

✅ This change can build next-swc

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2023

🟢 CI successful 🟢

Thanks

crates/turbopack-ecmascript/src/text/mod.rs Outdated Show resolved Hide resolved
crates/turbopack-static/src/fixed.rs Outdated Show resolved Hide resolved
crates/turbopack-static/src/fixed.rs Outdated Show resolved Hide resolved
@sokra sokra enabled auto-merge (squash) April 25, 2023 14:58
@sokra sokra merged commit f56af36 into main Apr 25, 2023
@sokra sokra deleted the sokra/metadata branch April 25, 2023 15:08
sokra added a commit to vercel/next.js that referenced this pull request Apr 27, 2023
### What?

* support local static metadata files; opengraph-image, twitter-image,
favicon, manifest, icon, apple-icon
* support global static metadata files: robots.txt, sitemap.xml,
favicon.ico
* dynamic metadata is not yet implemented, but yields a warning

It's implemented a bit different compared to the webpack version.
All images will use the usual image machinery, so they are emitted to
output directory, content hashed and the url is shared with the same
import import in the app.

### Why?

Unsupported, and we want to have that.

### How?

see also vercel/turborepo#4692

fixes WEB-524
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 25, 2024
### Description

needed for metadata support in next.js
(#48823)
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Jul 29, 2024
### Description

needed for metadata support in next.js
(#48823)
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 1, 2024
### Description

needed for metadata support in next.js
(#48823)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants