Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Add delegate votes management - Closes #24 #115

Merged
merged 37 commits into from
Apr 20, 2017
Merged

Add delegate votes management - Closes #24 #115

merged 37 commits into from
Apr 20, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Apr 13, 2017 •
edited by karmacoma
Loading

Add support for accounts to view and manage their delegate votes with the following key features.

  • Delegates listing
    • Search for delegates by username
    • Add or remove votes to/from selection of delegates
  • Select delegates for voting by a list of usernames
  • Review vote selection review before committal
  • My votes listing
    • Remove votes from selection of delegates

Closes #24

slaweet added 30 commits April 12, 2017 09:27
@slaweet
An initial mockup for Delegate vote management
c51b652
@slaweet
Make delegates mockup more condensed
2b58196
@slaweet
Fix "no delegates found" state
fdab0cb
@slaweet
Merge vote and unvote buttons
582d972
@slaweet
Finish vote for delegates dialog
ab74136
@slaweet
Add delegates infinite scroll
7d7ac3d
@slaweet
Label delegates checkbox column
c792bd3
@slaweet
Fix vote confirm button disable state
801f296
@slaweet
Make delegates search more visible and better
4776049
@slaweet
Polish the voting UI
4c85954
@slaweet
Remove delegates filter select
169f327 
to simplify UI as well as the code
because it didn't work well without server API support
@slaweet
Delegates refactoring
4f8b055
@slaweet
Create the first unit test for delegates component
72fbf98
@slaweet
Add support for voting with second passphrase
d63271c
@slaweet
Fix delegates search clear icon action
b459695
@slaweet
Delegates refactoring
eebd428
@slaweet
Fix vote dialog remove icon action
22a78a8
@slaweet
Remove no longer used boolFilter
32c5337
@slaweet
Update delegates list when a peer is changed
d547236
@slaweet
Preserve changed delegate status
251f548 
if search was done or peer changed
@slaweet
Move voting dialog to a separate component
ffd4b58 
for better testability
@slaweet
Create unit tests for delegates controller
7e8e4cf
@slaweet
Vote component refactoring
0889a3e
@slaweet
Create unit tests for vote component
1854cbe
@slaweet
Wrap lisk-js sendRequest with our own function
65845d0 
because otherwise the callbacks don't trigger angular digest cycle
@slaweet
Move clear votes from voting component to delegates
339682c
@slaweet
Refactor voting css
be7e13e
@slaweet
Add "My votes" button
7cecbcc
@slaweet
Create 'select list of delegates' feature
b804ad1
@slaweet
Refactor delegates controller function names
65cbdd1
@coveralls
Copy link

Coverage Status

Coverage increased (+3.8%) to 88.454% when pulling 85afa9d on 24_delegate-vote-management into a0cb4d7 on development.

@slaweet slaweet changed the base branch from development to 1.0.0 April 13, 2017 14:10
@slaweet slaweet requested a review from karmacoma April 13, 2017 14:12
@karmacoma karmacoma changed the title Add delegate votes management; closes #24 Add delegate votes management - Closes #24 Apr 13, 2017
@karmacoma karmacoma self-assigned this Apr 13, 2017
@karmacoma karmacoma changed the base branch from 1.0.0 to development April 13, 2017 16:13
@slaweet slaweet force-pushed the 24_delegate-vote-management branch from 9e23bb4 to a89f7a6 Compare April 18, 2017 09:05
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 83.268% when pulling a89f7a6 on 24_delegate-vote-management into a0cb4d7 on development.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 83.268% when pulling a89f7a6 on 24_delegate-vote-management into a0cb4d7 on development.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.01%) to 85.63% when pulling b177e16 on 24_delegate-vote-management into a0cb4d7 on development.

@slaweet
Start refactoring sendRequest calls
36679a2 
... into request-specific functions to encapsulate the API
@coveralls
Copy link

Coverage Status

Coverage increased (+2.5%) to 87.097% when pulling 36679a2 on 24_delegate-vote-management into a0cb4d7 on development.

karmacoma
karmacoma approved these changes Apr 20, 2017
View reviewed changes
Copy link
Contributor

@karmacoma karmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work @slaweet 👍

There are some improvements we can make, but I will open separate issues for these with screenshots.

@coveralls
Copy link

Coverage Status

Coverage increased (+2.4%) to 87.149% when pulling fa3acf4 on 24_delegate-vote-management into 761df6c on development.

@karmacoma karmacoma merged commit babe4a0 into development Apr 20, 2017
@karmacoma karmacoma deleted the 24_delegate-vote-management branch April 20, 2017 09:36
This was referenced Apr 25, 2017
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karmacoma karmacoma karmacoma approved these changes

Assignees

@karmacoma karmacoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slaweet @coveralls @karmacoma