Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Vote button should be disabled until delegates selected #140

Closed
karmacoma opened this issue Apr 25, 2017 · 0 comments
Closed

Vote button should be disabled until delegates selected #140

karmacoma opened this issue Apr 25, 2017 · 0 comments
Labels
bug
Milestone
Version 1.0.0

Comments

@karmacoma
Copy link
Contributor

karmacoma commented Apr 25, 2017 •
edited
Loading

Expected behaviour

Vote button should be disabled until delegates are selected.

Actual behaviour

Button is active by default. Therefore upon clicking it, a modal is opened with an empty vote listing.

lisk nano firefox today at 12 53 54

Steps to reproduce

  • Log into an account.
  • Navigate to "Voting" tab.
  • Do not select any delegates to vote for.
  • Click on "Vote".

Applies to: #115
@karmacoma karmacoma added the bug label Apr 25, 2017
@karmacoma karmacoma added this to the Version 1.0.0 milestone Apr 25, 2017
@slaweet slaweet self-assigned this Apr 25, 2017
slaweet added a commit that referenced this issue Apr 25, 2017
@slaweet
Disable vote button until delegates selected #140
c5176d1
@slaweet slaweet mentioned this issue Apr 26, 2017
Merged
karmacoma added a commit that referenced this issue Apr 26, 2017
@karmacoma
Merge pull request #143 from LiskHQ/140_disable-vote-button
365f77d 
Disable vote button until delegates selected - Closes #140
slaweet added a commit that referenced this issue May 2, 2017
@slaweet
Revert "Disable vote button until delegates selected #140"
8b96703 
This reverts commit c5176d1.

Now you can search delegates in the vote dialog, so it makes sense to
open it even when no delegates selected
@snyk-bot snyk-bot mentioned this issue Sep 23, 2020
Open
@snyk-bot snyk-bot mentioned this issue Jan 18, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
2 participants
@karmacoma @slaweet