Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Vote confirmation modal overflows, hiding header and footer #138

Closed
karmacoma opened this issue Apr 25, 2017 · 0 comments
Closed

Vote confirmation modal overflows, hiding header and footer #138

karmacoma opened this issue Apr 25, 2017 · 0 comments
Labels
bug
Milestone
Version 1.0.0

Comments

@karmacoma
Copy link
Contributor

Expected appearance

Modal container should not be allowed to overflow. Vote candidate listing within modal should be constrained and overflown beforehand. Header (with title) and footer (with buttons) should remain visible.

Actual appearance

lisk nano firefox wednesday 19 april 2017 at 12 57 49

Steps to reproduce

Select a number of delegates to be voted. Enough to cause overflow.

Applies to: #115
@karmacoma karmacoma added the bug label Apr 25, 2017
@karmacoma karmacoma added this to the Version 1.0.0 milestone Apr 25, 2017
@slaweet slaweet self-assigned this Apr 25, 2017
slaweet added a commit that referenced this issue Apr 26, 2017
@slaweet
Use md-chips in vote dialog.
197eb9e 
Fixes #138 by having multiple delegates on one line,
thus the list is not so high
slaweet added a commit that referenced this issue Apr 26, 2017
@slaweet
Use md-chips in vote dialog.
8e249fc 
Fixes #138 by having multiple delegates on one line,
thus the list is not so high
@slaweet slaweet mentioned this issue Apr 26, 2017
Merged
karmacoma added a commit that referenced this issue Apr 27, 2017
@karmacoma
Merge pull request #146 from LiskHQ/138_vote-list-too-high
4c09077 
Vote list too high - Fixes #138
@slaweet slaweet mentioned this issue May 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Version 1.0.0
Development

No branches or pull requests
2 participants
@karmacoma @slaweet