Skip to content
This repository has been archived by the owner on Apr 15, 2019. It is now read-only.

Vote list too high - Fixes #138 #146

Merged
merged 7 commits into from
Apr 27, 2017
Merged

Vote list too high - Fixes #138 #146

merged 7 commits into from
Apr 27, 2017

Conversation

slaweet
Copy link
Contributor

@slaweet slaweet commented Apr 26, 2017 •
edited by karmacoma
Loading

Use md-chips in vote dialog.

Fixes #138 by having multiple delegates on one line, thus the list is not so high.

slaweet added 4 commits April 26, 2017 12:39
@slaweet
Refactor delegate requests into new delegateService
b14e8de
@slaweet
Use md-chips in vote dialog.
8e249fc 
Fixes #138 by having multiple delegates on one line,
thus the list is not so high
@slaweet
Fix unit tests to pass
b0e6784
@slaweet
Revert "Disable "My Votes (0)" button #139"
7b2ca67 
This reverts commit d933906.

Now you can search delegates in the vote dialog, so it makes sense to
open it even when no delegates selected
@slaweet slaweet added this to the Version 1.0.0 milestone Apr 26, 2017
@slaweet slaweet requested a review from karmacoma April 26, 2017 10:44
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.5%) to 86.022% when pulling 130f339 on 138_vote-list-too-high into 126b197 on development.

@karmacoma karmacoma changed the title Vote list too high Vote list too high - Fixes #138 Apr 26, 2017
@karmacoma karmacoma added the bug label Apr 26, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 87.097% when pulling 05560bd on 138_vote-list-too-high into 126b197 on development.

@karmacoma karmacoma modified the milestone: Version 1.0.0 Apr 26, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.2%) to 85.37% when pulling f951313 on 138_vote-list-too-high into 126b197 on development.

karmacoma
karmacoma approved these changes Apr 27, 2017
View reviewed changes
Copy link
Contributor

@karmacoma karmacoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @slaweet 👍 This is more than expected, works really well, thanks.

@karmacoma karmacoma merged commit 4c09077 into development Apr 27, 2017
@karmacoma karmacoma deleted the 138_vote-list-too-high branch April 27, 2017 10:26
@slaweet slaweet mentioned this pull request May 2, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karmacoma karmacoma karmacoma approved these changes

Assignees

@karmacoma karmacoma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slaweet @coveralls @karmacoma