Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup logic in training type plugins [1 / n] #9994

Merged
merged 21 commits into from
Oct 19, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 18, 2021

What does this PR do?

Part of #9987

Adds methods for plugins to override how models and optimizers are setup.

The follow up PR(s) will add implementations for setup to DP, TPUSpawn, Deepspeed, etc.

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Make sure you had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 18, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 18, 2021
Copy link
Contributor

@SeanNaren SeanNaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do resonate with @four4fish, if we'd like to get this in before our release, we should try to comment/todo the introduced function which should be refactored once the precision plugin is moved into the TTP (I think out of scope for 1.5)

@awaelchli
Copy link
Contributor Author

@SeanNaren @four4fish Thanks for the suggestions! Added docs and TODO

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 1

@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@awaelchli awaelchli force-pushed the lightning-lite/refactors/ttp-setup branch from 937e32b to 6a13cf7 Compare October 19, 2021 09:35
awaelchli and others added 2 commits October 19, 2021 15:41
While currently the methods are primarily used by Lite, they will become more important ingredients later on for all Lightning and all plugins
@awaelchli awaelchli enabled auto-merge (squash) October 19, 2021 13:47
@awaelchli awaelchli merged commit 854bdc0 into master Oct 19, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/ttp-setup branch October 19, 2021 15:45
@four4fish
Copy link
Contributor

@awaelchli @tchaton @SeanNaren Thank you for the explanations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants