Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup logic in training type plugins (deepspeed) [2 / n] #10009

Merged
merged 10 commits into from
Oct 19, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 19, 2021

What does this PR do?

Part of #9987
Follow up to #9994

Implements _setup_models_and_optimizers for the Deepspeed plugin

Does your PR introduce any breaking changes? If yes, please list them.

No.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added refactor design Includes a design discussion labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

Base automatically changed from lightning-lite/refactors/ttp-setup to master October 19, 2021 15:45
@awaelchli awaelchli marked this pull request as ready for review October 19, 2021 15:53
@mergify mergify bot added the ready PRs ready to be merged label Oct 19, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 19, 2021 16:15
@codecov
Copy link

codecov bot commented Oct 19, 2021

Codecov Report

Merging #10009 (40df8e6) into master (e8beceb) will increase coverage by 4%.
The diff coverage is 56%.

@@           Coverage Diff            @@
##           master   #10009    +/-   ##
========================================
+ Coverage      89%      93%    +4%     
========================================
  Files         180      180            
  Lines       15854    15868    +14     
========================================
+ Hits        14066    14685   +619     
+ Misses       1788     1183   -605     

@mergify mergify bot removed the has conflicts label Oct 19, 2021
@awaelchli awaelchli merged commit 3ea5347 into master Oct 19, 2021
@awaelchli awaelchli deleted the lightning-lite/refactors/deepspeed-setup-2 branch October 19, 2021 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants