-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict setup methods to accept a single model #10064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
changed the title
Restrict setup methods to one model
Restrict setup methods to accept a single model
Oct 21, 2021
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 21, 2021 13:35
carmocca
approved these changes
Oct 21, 2021
four4fish
reviewed
Oct 21, 2021
tchaton
approved these changes
Oct 21, 2021
rohitgr7
approved these changes
Oct 21, 2021
Codecov Report
@@ Coverage Diff @@
## master #10064 +/- ##
=========================================
+ Coverage 43% 92% +50%
=========================================
Files 182 182
Lines 16109 16107 -2
=========================================
+ Hits 6874 14892 +8018
+ Misses 9235 1215 -8020 |
ninginthecloud
pushed a commit
to ninginthecloud/pytorch-lightning
that referenced
this pull request
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
#9994 added a setup method
setup_models_and_optimizers
and this PR updates this to accept only a single model.Follow up to the discussion in #10028 (comment) @four4fish
Does your PR introduce any breaking changes? If yes, please list them.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃