Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict setup methods to accept a single model #10064

Merged
merged 10 commits into from
Oct 25, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 21, 2021

What does this PR do?

#9994 added a setup method setup_models_and_optimizers and this PR updates this to accept only a single model.
Follow up to the discussion in #10028 (comment) @four4fish

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli changed the title Restrict setup methods to one model Restrict setup methods to accept a single model Oct 21, 2021
@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 21, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 21, 2021
@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10064 (b4e5ab4) into master (e94dcf6) will increase coverage by 50%.
The diff coverage is 67%.

❗ Current head b4e5ab4 differs from pull request most recent head 8e76000. Consider uploading reports for the commit 8e76000 to get more accurate results

@@            Coverage Diff            @@
##           master   #10064     +/-   ##
=========================================
+ Coverage      43%      92%    +50%     
=========================================
  Files         182      182             
  Lines       16109    16107      -2     
=========================================
+ Hits         6874    14892   +8018     
+ Misses       9235     1215   -8020     

@mergify mergify bot removed the has conflicts label Oct 22, 2021
@awaelchli awaelchli enabled auto-merge (squash) October 22, 2021 03:47
@awaelchli awaelchli mentioned this pull request Oct 23, 2021
23 tasks
@awaelchli awaelchli merged commit d3e5a43 into master Oct 25, 2021
@awaelchli awaelchli deleted the refactor/setup-one-model branch October 25, 2021 16:32
ninginthecloud pushed a commit to ninginthecloud/pytorch-lightning that referenced this pull request Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants