-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update setup logic in training type plugins (sharded) [4 / 4] #10028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
rohitgr7,
SeanNaren,
tchaton and
williamFalcon
as code owners
October 20, 2021 04:50
Codecov Report
@@ Coverage Diff @@
## master #10028 +/- ##
========================================
- Coverage 93% 89% -4%
========================================
Files 180 180
Lines 15912 15929 +17
========================================
- Hits 14726 14105 -621
- Misses 1186 1824 +638 |
justusschock
approved these changes
Oct 20, 2021
kaushikb11
reviewed
Oct 20, 2021
kaushikb11
reviewed
Oct 20, 2021
kaushikb11
approved these changes
Oct 20, 2021
SeanNaren
approved these changes
Oct 20, 2021
tchaton
approved these changes
Oct 20, 2021
four4fish
reviewed
Oct 20, 2021
This was referenced Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Part of #9987
Follow up to #10010
Implements the
_setup_models_and_optimizers()
method for the sharded plugins. I'm updating both sharded plugins at the same time because their code is nearly identical. I make sure to reduce code duplication by refactoring the access to the helper methods that wrap the optimizers in OSS. Note however, this does not cover the FullySharded plugin.Does your PR introduce any breaking changes? If yes, please list them.
No. Two signatures were changed but they are part of protected API.
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃