Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup logic in training type plugins (sharded) [4 / 4] #10028

Merged
merged 8 commits into from
Oct 21, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 19, 2021

What does this PR do?

Part of #9987
Follow up to #10010

Implements the _setup_models_and_optimizers() method for the sharded plugins. I'm updating both sharded plugins at the same time because their code is nearly identical. I make sure to reduce code duplication by refactoring the access to the helper methods that wrap the optimizers in OSS. Note however, this does not cover the FullySharded plugin.

Does your PR introduce any breaking changes? If yes, please list them.

No. Two signatures were changed but they are part of protected API.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added design Includes a design discussion refactor labels Oct 19, 2021
@awaelchli awaelchli added this to the v1.5 milestone Oct 19, 2021
@codecov
Copy link

codecov bot commented Oct 20, 2021

Codecov Report

Merging #10028 (c121f63) into master (d419028) will decrease coverage by 4%.
The diff coverage is 38%.

@@           Coverage Diff            @@
##           master   #10028    +/-   ##
========================================
- Coverage      93%      89%    -4%     
========================================
  Files         180      180            
  Lines       15912    15929    +17     
========================================
- Hits        14726    14105   -621     
- Misses       1186     1824   +638     

@mergify mergify bot added the ready PRs ready to be merged label Oct 20, 2021
@tchaton tchaton enabled auto-merge (squash) October 20, 2021 20:43
@mergify mergify bot removed the has conflicts label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Includes a design discussion ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants