Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant require_backward_grad_sync=False in sharded plugins #10065

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Oct 21, 2021

What does this PR do?

Attempt to remove redundant setattr(model, "require_backward_grad_sync", False) call in sharded plugins.
Addresses comment in #10028 (comment)

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

@awaelchli awaelchli added this to the v1.5 milestone Oct 21, 2021
@awaelchli awaelchli marked this pull request as ready for review October 21, 2021 13:34
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@mergify mergify bot added the ready PRs ready to be merged label Oct 21, 2021
Copy link
Contributor

@four4fish four4fish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing this in a different PR

@awaelchli awaelchli enabled auto-merge (squash) October 21, 2021 19:40
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #10065 (7020bdb) into master (c3614f1) will decrease coverage by 0%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10065   +/-   ##
=======================================
- Coverage      92%      92%   -0%     
=======================================
  Files         182      182           
  Lines       16113    16111    -2     
=======================================
- Hits        14896    14894    -2     
  Misses       1217     1217           

@awaelchli awaelchli merged commit 8482c28 into master Oct 22, 2021
@awaelchli awaelchli deleted the feature/remove-sharded-require-sync branch October 22, 2021 03:07
awaelchli added a commit that referenced this pull request Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready PRs ready to be merged refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants