-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync CI configuration into 1.5.x branch #10738
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, tests are green.
Remember to update the CHANGELOG: https://github.com/PyTorchLightning/pytorch-lightning/blame/master/CHANGELOG.md#L130
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Sync CI configuration into 1.5.x branch
Sync CI configuration into 1.5.x branch
What does this PR do?
Syncs the CI configuration from master, dropping the support for torch 1.6 and fixing our CI jobs here.
All changes in these files are now identical to the ones on master, no other changes were done here.
Done via
git checkout master .github/workflows requirements/ ... etc.
These are the PRs that updated the configuration on master:
#10367
#10075
#10088
#10390
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
I made sure I had fun coding 🙃
Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)
cc @carmocca @akihironitta @Borda