Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Patch Release v1.5.4 #10732

Merged
merged 11 commits into from
Nov 30, 2021
Merged

Weekly Patch Release v1.5.4 #10732

merged 11 commits into from
Nov 30, 2021

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Nov 24, 2021

What does this PR do?

Contains all bugfixes to be released next week. As bugfixes get merged to master, they will get cherry-picked into this branch by the individual author (core) or on-caller.

For staff/core: The new release guide is here.

gh pr list -s merged -S 'merged:2021-11-24T18:30:00.000Z..2021-11-30T18:30:00.000Z' --json mergedAt,milestone,url,mergeCommit,title --jq 'sort_by(.mergedAt) | reverse | .[] | select((.milestone.title == 
"1.5.x") or (.milestone.title == null)) | [.mergedAt, .url, .mergeCommit.oid, .title] | join(" ")' --limit 100


Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

I made sure I had fun coding 🙃

Part of #1 (it's a lie, this is just here to avoid noisy GitHub bot)

cc @Borda

@awaelchli awaelchli added bug Something isn't working release labels Nov 24, 2021
@awaelchli awaelchli added this to the 1.5.x milestone Nov 24, 2021
@awaelchli
Copy link
Contributor Author

Reminder: rebase onto 1.5.x after #10738

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Nov 30, 2021
@lexierule lexierule merged commit 20bef83 into release/1.5.x Nov 30, 2021
@lexierule lexierule deleted the 1.5.4-draft branch November 30, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready PRs ready to be merged release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants