Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete TensorBoardLogger experiment before spawning the processes. #10777

Merged
merged 16 commits into from
Nov 26, 2021
Merged

Delete TensorBoardLogger experiment before spawning the processes. #10777

merged 16 commits into from
Nov 26, 2021

Conversation

tchaton
Copy link
Contributor

@tchaton tchaton commented Nov 26, 2021 •
edited by github-actions bot
Loading

What does this PR do?

Fixes #<issue_number>

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

cc @Borda @tchaton @awaelchli @edward-io

@tchaton tchaton marked this pull request as ready for review November 26, 2021 15:00
@tchaton tchaton self-assigned this Nov 26, 2021
@tchaton tchaton added the bug Something isn't working label Nov 26, 2021
@tchaton tchaton added this to the 1.5.x milestone Nov 26, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

5 similar comments
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

@tchaton tchaton changed the title CI debug Delete TensorBoardLogger experiment before spawning the processes. Nov 26, 2021
@github-actions
Copy link
Contributor

Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id>

rohitgr7
rohitgr7 approved these changes Nov 26, 2021
View reviewed changes
Copy link
Contributor

@rohitgr7 rohitgr7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to add a test?

pytorch_lightning/plugins/training_type/ddp_spawn.py Outdated Show resolved Hide resolved
@carmocca carmocca added the priority: 0 High priority task label Nov 26, 2021
@mergify mergify bot added the ready PRs ready to be merged label Nov 26, 2021
@tchaton tchaton enabled auto-merge (squash) November 26, 2021 16:39
@tchaton tchaton merged commit 6fe6e9e into master Nov 26, 2021
@tchaton tchaton deleted the test_ci branch November 26, 2021 17:07
awaelchli pushed a commit that referenced this pull request Nov 27, 2021
@tchaton @awaelchli
Delete TensorBoardLogger experiment before spawning the processes. (#…
15bbfac 
…10777)
kaushikb11
kaushikb11 reviewed Nov 29, 2021
View reviewed changes
pytorch_lightning/plugins/training_type/ddp_spawn.py
loggers = trainer.logger._logger_iterable if isinstance(trainer.logger, LoggerCollection) else [trainer.logger]
for logger in loggers:
if isinstance(logger, TensorBoardLogger) and logger._experiment is not None:
rank_zero_warn(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchaton Is it necessary to have this warning? This info won't be necessary for majority of users.

And this warning pops up every time a user trains with ddp_spawn, ddp_spawn_sharded and tpu_spawn as TensorBoard logger is the default.

@kaushikb11 kaushikb11 mentioned this pull request Nov 29, 2021
Closed
12 tasks
lexierule pushed a commit that referenced this pull request Nov 30, 2021
@tchaton @lexierule
Delete TensorBoardLogger experiment before spawning the processes. (#…
7f147ee 
…10777)
@rohitgr7 rohitgr7 mentioned this pull request Feb 7, 2022
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaushikb11 kaushikb11 kaushikb11 left review comments

@rohitgr7 rohitgr7 rohitgr7 approved these changes

@carmocca carmocca carmocca approved these changes

@awaelchli awaelchli awaelchli approved these changes

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@Borda Borda Awaiting requested review from Borda Borda is a code owner

Assignees

@tchaton tchaton

Labels
bug Something isn't working logger: tensorboard priority: 0 High priority task ready PRs ready to be merged
Projects
None yet
Milestone
pl:1.5.x
Development

Successfully merging this pull request may close these issues.
5 participants
@tchaton @awaelchli @carmocca @rohitgr7 @kaushikb11