-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop torch 1.6 support #10367
Drop torch 1.6 support #10367
Conversation
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall.
I think whereever possible (all runs/images with python 3.8) we should still fall back to 1.7 and only for the 3.9 versions lift it to 1.7.1
Co-authored-by: Aki Nitta <[email protected]>
edit: found a solution using wildcard in c498a3b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Does this mean we can also deprecate the following lines and remove it in pl v1.7, right?
yes, in #10390 |
@carmocca I would rather keep it on master as we are going to merge bug fixes which will be conservatively cherry picked to |
@Borda This PR should have landed with 1.5 already to comply with the 4 torch versions window. Still, this can be merged to master and the milestone changed if you want to land a specific fix for 1.5.0 with 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
What does this PR do?
We have a 4 PyTorch version policy. With the release of 1.10, that means we can drop 1.6
[1.6, 1.7, 1.8, 1.9, 1.10] -> [1.7, 1.8, 1.9, 1.10]
Part of #10075
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review