Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve typing coverage #7037

Closed
tchaton opened this issue Apr 15, 2021 · 7 comments
Closed

Improve typing coverage #7037

tchaton opened this issue Apr 15, 2021 · 7 comments
Labels
code quality good first issue Good for newcomers help wanted Open to be worked on refactor

Comments

@tchaton
Copy link
Contributor

tchaton commented Apr 15, 2021

Please make one PR per file!

The list of pending files is can be found below here

https://github.com/Lightning-AI/lightning/blob/master/pyproject.toml#L39-L43

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7

@tchaton tchaton added feature Is an improvement or enhancement help wanted Open to be worked on labels Apr 15, 2021
@tchaton tchaton pinned this issue Apr 15, 2021
@tchaton tchaton changed the title Lightning Typing, Lightning Typing Apr 15, 2021
@Borda
Copy link
Member

Borda commented Apr 15, 2021

Duplicate to #5023

@Borda Borda closed this as completed Apr 15, 2021
@tchaton tchaton reopened this Apr 15, 2021
@Borda Borda added duplicate This issue or pull request already exists refactor labels Apr 15, 2021
@edenlightning edenlightning removed the duplicate This issue or pull request already exists label Apr 20, 2021
@justusschock justusschock mentioned this issue Apr 20, 2021
11 tasks
@akihironitta
Copy link
Contributor

#7035 (comment)

Open for discussion: Should we also type the tests? I don't think we have to!

I don't think we need type annotations in the tests, but we should run mypy to check if variables/functions of the package are correctly typed. What do you think?

@stancld
Copy link
Contributor

stancld commented Apr 23, 2021

After the chat with Eden, I'll tackle lightning.utilities :)

@stancld
Copy link
Contributor

stancld commented May 16, 2021

Hello @tchaton, I noticed new information about making one PR per file was added to the first comment. As I've been dealing with some mypy issues, my PR #7218 has become quite heavy. Is it, therefore, appropriate to close this PR, though already with a few reviews given, and open new ones separately for each file? Thanks :)

@Borda
Copy link
Member

Borda commented May 26, 2021

@tchaton what is the status here? 🐰

@stale stale bot added the won't fix This will not be worked on label Jun 25, 2021
@kaushikb11 kaushikb11 removed the won't fix This will not be worked on label Jun 25, 2021
@stale stale bot added the won't fix This will not be worked on label Jul 26, 2021
@Lightning-AI Lightning-AI deleted a comment from stale bot Jan 11, 2022
@Lightning-AI Lightning-AI deleted a comment from stale bot Jan 11, 2022
@carmocca carmocca modified the milestones: 1.6, None Feb 1, 2022
@carmocca carmocca added good first issue Good for newcomers and removed feature Is an improvement or enhancement labels Feb 1, 2022
@kingjuno
Copy link
Contributor

@tchaton Can I work on these 3?
pytorch_lightning.callbacks.finetuning
pytorch_lightning.callbacks.model_checkpoint
pytorch_lightning.callbacks.progress.rich_progress

@carmocca carmocca pinned this issue Jun 28, 2022
@carmocca carmocca changed the title Lightning Typing Improve typing coverage Jun 28, 2022
@otaj
Copy link
Contributor

otaj commented Jun 29, 2022

@kingjuno, you're more than welcome to help! We are closing this issue in favor of #13445 in order to promote better visibility, please feel free to comment there.

@otaj otaj closed this as completed Jun 29, 2022
@otaj otaj unpinned this issue Jun 29, 2022
@carmocca carmocca removed this from the future milestone Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality good first issue Good for newcomers help wanted Open to be worked on refactor
Projects
None yet
Development

No branches or pull requests

10 participants