-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve typing coverage #7037
Comments
Duplicate to #5023 |
I don't think we need type annotations in the tests, but we should run mypy to check if variables/functions of the package are correctly typed. What do you think? |
After the chat with Eden, I'll tackle lightning.utilities :) |
Hello @tchaton, I noticed new information about making one PR per file was added to the first comment. As I've been dealing with some mypy issues, my PR #7218 has become quite heavy. Is it, therefore, appropriate to close this PR, though already with a few reviews given, and open new ones separately for each file? Thanks :) |
@tchaton what is the status here? 🐰 |
@tchaton Can I work on these 3? |
Please make one PR per file!
The list of pending files is can be found below here
https://github.com/Lightning-AI/lightning/blob/master/pyproject.toml#L39-L43
cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7
The text was updated successfully, but these errors were encountered: