-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typing to accelerators/gpu.py #11333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Codecov Report
@@ Coverage Diff @@
## master #11333 +/- ##
========================================
Coverage 92% 92%
========================================
Files 194 194
Lines 17001 17710 +709
========================================
+ Hits 15623 16299 +676
- Misses 1378 1411 +33 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the new annotations!
c1449fe
to
c14223a
Compare
What does this PR do?
Part of #7037
Part of #11205
I'm going to try and always have one typing PR open for reviews :)
Does your PR introduce any breaking changes? If yes, please list them.
None
Before submitting
PR review
cc @Borda