Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing to accelerators/gpu.py #11333

Merged
merged 6 commits into from
Jan 12, 2022
Merged

Add typing to accelerators/gpu.py #11333

merged 6 commits into from
Jan 12, 2022

Conversation

carmocca
Copy link
Contributor

@carmocca carmocca commented Jan 5, 2022

What does this PR do?

Part of #7037
Part of #11205

I'm going to try and always have one typing PR open for reviews :)

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @Borda

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@carmocca carmocca marked this pull request as draft January 6, 2022 17:54
@carmocca carmocca marked this pull request as ready for review January 10, 2022 14:19
@codecov
Copy link

codecov bot commented Jan 10, 2022

Codecov Report

Merging #11333 (71ca214) into master (9771040) will increase coverage by 0%.
The diff coverage is 85%.

❗ Current head 71ca214 differs from pull request most recent head 66379d0. Consider uploading reports for the commit 66379d0 to get more accurate results

@@           Coverage Diff            @@
##           master   #11333    +/-   ##
========================================
  Coverage      92%      92%            
========================================
  Files         194      194            
  Lines       17001    17710   +709     
========================================
+ Hits        15623    16299   +676     
- Misses       1378     1411    +33     

Copy link
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@mergify mergify bot added the ready PRs ready to be merged label Jan 11, 2022
@carmocca carmocca requested a review from akihironitta January 12, 2022 01:55
@carmocca carmocca enabled auto-merge (squash) January 12, 2022 01:56
Copy link
Contributor

@akihironitta akihironitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the new annotations!

@carmocca carmocca merged commit 5914fb7 into master Jan 12, 2022
@carmocca carmocca deleted the typing/device-gpu branch January 12, 2022 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants