-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typing callbacks #7042
Typing callbacks #7042
Conversation
Hello @justusschock! Thanks for updating this PR. There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-04-21 08:19:31 UTC |
@justusschock how far are we, mind list what is missing so others may help/contribute? 🐰 |
6241792
to
f21cd0e
Compare
Codecov Report
@@ Coverage Diff @@
## master #7042 +/- ##
=======================================
- Coverage 92% 86% -6%
=======================================
Files 197 197
Lines 12662 12856 +194
=======================================
- Hits 11661 11012 -649
- Misses 1001 1844 +843 |
@justusschock Why close this? You could open PRs for separate callbacks, for example, pruning should be ready to go |
What does this PR do?
Part of #5023 and #7037
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃