Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typing callbacks #7042

Closed
wants to merge 48 commits into from
Closed

Typing callbacks #7042

wants to merge 48 commits into from

Conversation

justusschock
Copy link
Member

@justusschock justusschock commented Apr 15, 2021

What does this PR do?

Part of #5023 and #7037

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@pep8speaks
Copy link

pep8speaks commented Apr 15, 2021

Hello @justusschock! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-21 08:19:31 UTC

@Borda Borda added the refactor label Apr 18, 2021
@Borda
Copy link
Member

Borda commented Apr 18, 2021

@justusschock how far are we, mind list what is missing so others may help/contribute? 🐰

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #7042 (7c7a443) into master (e4f3a8d) will decrease coverage by 6%.
The diff coverage is 89%.

@@           Coverage Diff           @@
##           master   #7042    +/-   ##
=======================================
- Coverage      92%     86%    -6%     
=======================================
  Files         197     197            
  Lines       12662   12856   +194     
=======================================
- Hits        11661   11012   -649     
- Misses       1001    1844   +843     

@justusschock justusschock marked this pull request as ready for review April 20, 2021 13:26
@carmocca
Copy link
Contributor

carmocca commented May 3, 2021

@justusschock Why close this? You could open PRs for separate callbacks, for example, pruning should be ready to go

@Borda Borda deleted the typing_callbacks branch May 10, 2021 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants