Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typing for utilities/memory.py #11545

Merged
merged 4 commits into from
Feb 3, 2022
Merged

Conversation

DuYicong515
Copy link
Contributor

@DuYicong515 DuYicong515 commented Jan 19, 2022

What does this PR do?

Part of Fixes for #7037, #5023.

Does your PR introduce any breaking changes? If yes, please list them.

None

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • [n/a] Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • [N/A] Add labels and milestones (and optionally projects) to the PR so it can be classified

cc @ananthsub

Copy link
Contributor

@ananthsub ananthsub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@DuYicong515 DuYicong515 requested a review from carmocca January 19, 2022 23:11
@mergify mergify bot added the ready PRs ready to be merged label Jan 20, 2022
@carmocca carmocca enabled auto-merge (squash) January 20, 2022 19:42
auto-merge was automatically disabled January 24, 2022 17:59

Head branch was pushed to by a user without write access

@rohitgr7 rohitgr7 enabled auto-merge (squash) January 24, 2022 18:11
auto-merge was automatically disabled January 24, 2022 18:59

Head branch was pushed to by a user without write access

@justusschock justusschock enabled auto-merge (squash) January 25, 2022 10:26
auto-merge was automatically disabled February 2, 2022 21:34

Head branch was pushed to by a user without write access

@carmocca carmocca merged commit 0816a19 into Lightning-AI:master Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality ready PRs ready to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants