Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flex upgrade #7

Merged
merged 59 commits into from
Aug 1, 2024
Merged

Flex upgrade #7

merged 59 commits into from
Aug 1, 2024

Conversation

ajinkyaraj-23
Copy link

Checklist

  • App update process has been followed
  • Target branch is develop
  • Application version has been bumped

Changes

  • Port the wallet app to the new design guidelines for stax and flex.
  • Change blindsigning flow according to the guideline for stax/flex and nano devices.
  • Use useCaseReviewStreaming for stax/flex as we are using streaming parser.
  • Add flex tests

spalmer25 and others added 30 commits July 5, 2024 09:04
@spalmer25
[test] fix stax tests
f25de34 
ragger.firmware.stax has been replaced by ragger.firmware.touch with
the introduction of flex device
@spalmer25
[test] fix stax snapshots
3a886e5
@spalmer25
[test] ignore speculos disconnection errors when closing the app
f3d5c51
@spalmer25
[.github/workflows] handle artifact using v4
69811a1
@ajinkyaraj-23
Merge pull request #243 from trilitech/palmer@functori@bump-ragger-ve…
b40b930 
…rsion

Bump ragger version
@spalmer25
Merge pull request #242 from trilitech/palmer@functori@bump-github-ar…
7e661da 
…tifact-version

Bump actions/upload-artifact and actions/download-artifact version to v4
@ajinkyaraj-23
Move stax fixed screens to parent folder. (#241)
493270f 
update version and add provision for stax ragger tests in nano.
@ajinkyaraj-23
Use the guideline provided useCaseHomeAndSettings use case.
fc3f351
@ajinkyaraj-23
use useCaseAddressReview from ledger guidelines for stax
5b62b99
@ajinkyaraj-23
Merge pull request #246 from trilitech/ajinkyaraj-23@239-use-latest-n…
5b34ffe 
…bgl-usecase-functions-for-stax

Use the guideline provided useCaseHomeAndSettings use case.
@spalmer25
[test] remove unused code and snapshots
9309fc5
@spalmer25
[test] use assert_home, assert_info, assert_settings to ease reading
cd17053
@spalmer25
[test] use functions where the code is duplicated
f883974
@spalmer25
[test] move golden as argument
2efabd9
@spalmer25
[test] explicit TezosAppScreen field
f99b9eb 
Move the ChoiceList __settings as layout
@spalmer25
[test] customize use_cases for our app
8b7826b
@spalmer25
[test] introduce a ticker pause/resume contextmanager
e3af7cb
@spalmer25
[stax] fix warning
2e0ffa6 
by changing `C_round_warning_64px with `C_Important_Circle_64px` that
is similar
@spalmer25
[test] fix test according to the new stax display/feature
d42582b 
 - screen contains more data: number of screen reduced
 - swipe instead of tap
 - QR button has moved
@spalmer25
[test] fix ragger touch positions
f07f1b2 
Position are fixed in Ragger v1.21.0
@spalmer25
Merge pull request #249 from trilitech/palmer@functori@stax-tests-update
e624d29 
Stax tests update
@spalmer25
[test] remove hard-coded stax naming
58dbaec
@spalmer25
[flex] allow flex app build
3d896c7
@spalmer25
[test] add test for flex
26f9e30
@spalmer25
[flex] add flex on doc and CI
0aa45bb
@ajinkyaraj-23
Merge pull request #247 from trilitech/palmer@functori@flex-support
361f1f4 
Flex support
@ajinkyaraj-23
Replace blindsigning flow to match the guidelines
cdd4fc7 
If blindsigning is required, show two warning screens , the 2nd being details about the error.
Standardize the msgs shown in confirm trasaction/rejection screens using macros.
@ajinkyaraj-23
Remove blindsign setting button from settings screen on stax/flex
37e04ae
@ajinkyaraj-23
Update snapshots for new blindsigning flow
469276a 
1. test_basic.py - remove blindsigning settings from settings menu
2. test_blindsign_too_deep.py - Remove blindsign enabled section and consolidate two warning screens in one utils function.
3. test_blindsign_too_deep_rejections.py - Address changes due to two warning screens. Note that first warning screen has reverse confirm/reject buttons
4. test_blindsign_too_large.py - Remove blindsign enabled section.
5. test_parsing_errors.py - add the blindsign warning screen. note that the warning screen has reverse confirm/reject buttons.
@ajinkyaraj-23
Make sure info.png is deleted and regenerated only in test_basic.py
52d748e 
info.png is deleted on unrelated golden snapshot generations.
ajinkyaraj-23 and others added 28 commits July 18, 2024 08:05
@ajinkyaraj-23
Merge pull request #248 from trilitech/ajinkyaraj-23@remove-blindsign…
c44150e 
…-button

Change blindsign flow according to guideline.
@spalmer25
Add Ticket to the formatter
a30542f
@spalmer25
Merge pull request #255 from trilitech/palmer@functori@add-michelson-…
ce9343f 
…primitive-D_Ticket

Add michelson `D_Ticket` to the formatter
@spalmer25
[test] removes unused snapshots
d9d13bc
@ajinkyaraj-23
Reset global error code at the beginning of each stream
4a96bfc
@ajinkyaraj-23
Use useCaseStreamingStart to start the display stream for stax/flex d…
138370a 
…isplay
@ajinkyaraj-23
Use useCaseReviewStreamingContinue and integrate with ui_nav_cb() fun…
4377a3b 
…ction
@ajinkyaraj-23
Update tests snapshots for touch devices
401b07d
@spalmer25
[blindsigning] remove blindsigning parameters
22caacd 
Blindsigning always activated.
i.e. if the message to sign is not parsable, alert risk and ask sign
without showing precise message's information
@spalmer25
[touch] change the tiny-url
48f1bc9 
From `tinyurl.com/Tezos-ledger` to `bit.ly/ledger-tez`.
In order to have the same url on nano device.
Change because the old one does not fit properly on nano screens.
@spalmer25
[blind-signing] Reset screens stream at blindsigning requests
cddca5e
@spalmer25
[format] do not clang-format on the refill error flow
89ace31 
To make the flow easier to read
@spalmer25
[blindsigning] update blindsigning request flow to a standard flow
85a0f5c
@spalmer25
Merge pull request #257 from trilitech/palmer@functori@standard-nano-…
efb6737 
…blindsigning

Standard nano blindsigning
@ajinkyaraj-23
Merge pull request #258 from trilitech/254-use-usecasestreaming-for-stax
48f7f55 
254 use usecasestreaming for stax
@spalmer25
[glyphs] remove unused glyphs
5856ddb
@ajinkyaraj-23
Remove duplicate reject UI page.
0e1b99c 
The reviewStreamingFinish already provides a reject confirmation page.
@spalmer25
[ux.bagls] fix bagls length
a80734b 
TZ_SCREEN_LINES + background + left & right arrow + optionnal icon
@ajinkyaraj-23
Test removal of duplicate reject UI
1bdb303
@spalmer25
[layout_type] associate layouts differentiated only by HOME_MASK
f86232d
@spalmer25
[ui] allowing icon only on top
e96f26a 
i.e. PB for our current usage
@spalmer25
[ui] center the lines on HOME mask
ef29bdc
@spalmer25
[blindsigning] use HOME mask for warning screen
f8c482c
@spalmer25
[test] remove redundant code
ee7c2fe 
- ledger-app-builder == 3.30.0
- ragger             == 1.21.1
- speculos           == 0.9.6
@ajinkyaraj-23
Merge pull request #262 from trilitech/261-duplicate-rejection-pages-…
5e961e9 
…at-last-signing-page

261 duplicate rejection pages at last signing page
@ajinkyaraj-23
Merge pull request #263 from trilitech/palmer@functori@fix-blindsigni…
60e819d 
…ng-warning-arrows

Fix blindsigning warning arrows
@ajinkyaraj-23
Merge pull request #264 from trilitech/palmer@functori@bump-ledger-ap…
b4d7a8b 
…p-builder-version

Bump `ledger-app-builder` version
@ajinkyaraj-23
Use useCaseViewDetails to show tag-value pair which does not fit in s…
953b699 
…ingle page.

- fixes #260
@agrojean-ledger agrojean-ledger merged commit 6e4b8ef into LedgerHQ:develop Aug 1, 2024
141 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agrojean-ledger agrojean-ledger agrojean-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ajinkyaraj-23 @agrojean-ledger @spalmer25