Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blindsigning warning arrows #263

Merged
merged 6 commits into from
Jul 25, 2024

Conversation

spalmer25
Copy link
Collaborator

@spalmer25 spalmer25 commented Jul 24, 2024

Before the fix, the HOME mask was applied only on 2 lines screens and did not work properly for screens with more or less lines.
This PR centres the lines vertically, regardless of their number, when the screen layout includes the HOME mask.

TZ_SCREEN_LINES + background + left & right arrow + optionnal icon
@spalmer25 spalmer25 added app::wallet issues relating to the wallet app device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device labels Jul 24, 2024
@spalmer25 spalmer25 self-assigned this Jul 24, 2024
@spalmer25 spalmer25 linked an issue Jul 24, 2024 that may be closed by this pull request
app/src/ui_stream.c Fixed Show resolved Hide resolved
@spalmer25 spalmer25 marked this pull request as draft July 24, 2024 17:19
@spalmer25 spalmer25 force-pushed the palmer@functori@fix-blindsigning-warning-arrows branch from 5b03c1c to f8c482c Compare July 24, 2024 17:24
@spalmer25 spalmer25 marked this pull request as ready for review July 24, 2024 17:26
@spalmer25 spalmer25 requested a review from ajinkyaraj-23 July 24, 2024 17:27
Copy link
Collaborator

@ajinkyaraj-23 ajinkyaraj-23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ajinkyaraj-23 ajinkyaraj-23 merged commit 60e819d into main Jul 25, 2024
143 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app::wallet issues relating to the wallet app device::NANOSP Issues affecting NANOSP device device::NANOX Issues affecting NANOX device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix blind-signing warning screens arrows
2 participants