Stax tests update #249
Merged
Stax tests update #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the ChoiceList __settings as layout
spalmer25
added
app::wallet
by changing `C_round_warning_64px with `C_Important_Circle_64px` that is similar
- screen contains more data: number of screen reduced - swipe instead of tap - QR button has moved
spalmer25
force-pushed
the
palmer@functori@stax-tests-update
branch
2 times, most recently
from
6f35269 to
2b30600
Compare
Position are fixed in Ragger v1.21.0
spalmer25
force-pushed
the
palmer@functori@stax-tests-update
branch
from
2b30600 to
c5817e8
Compare
spalmer25
force-pushed
the
palmer@functori@stax-tests-update
branch
from
c5817e8 to
f07f1b2
Compare
This was referenced Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Staxdisplay has been updated.This PR updates
Staxtests accordingly.Two of the display changes will require changes to our code:
Warningbutton has been added to some screens. We should understand when we want them to be displayed and have a test to ensure its behaviour: [Test] Add test for the review warning button #250.It is also not displayed well in some cases: [BUG] Review warning button overridden #251. For example: