Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Android in Talkbalk (screenreader) it is not possible to select a suggestion from the list #17252

Closed
nico-amsterdam opened this issue Mar 30, 2024 · 1 comment
Closed

On Android in Talkbalk (screenreader) it is not possible to select a suggestion from the list #17252

nico-amsterdam opened this issue Mar 30, 2024 · 1 comment

Comments

@nico-amsterdam
Copy link
Contributor

Tested this on a Android phone width Talkback 14.1 (currently the latest) on Chrome .
I can type something in the input field, but if I want to select something from the suggestions it selects the whole UL listbox, and it is not possible to select one item.
Turns out the the LI items in the suggestion list must be put in the tab sequence.
If you add the following in the _ITEM function in awesomplete.js, below line 381, it works fine:
"tabindex": "0",

Although Awesomplete works great, the whole project could use a bit of LOVE.

  • 95% of the issues can be closed with the remark: 'functions as designed' or 'closed due to 2 years of inactivity' or 'won't fix' or 'workaround can be made with a little bit of effort'. Currently the project looks abandoned.
  • The listLabel text can be configured, but the other a11y text (status.textContent) not. This would be useful if you want tot use Awesomplete in a different language with a screenreader. Not every blind person understands English, if you pardon my French :-)
  • And a minor bug: in the destroy function, the attribute 'aria-autocomplete' is removed (line 227), but this attribute is never set by Awesomplete. Looks like it is missing around line 22. And shouldn't the other attributes (aria-owns for example) be removed in the destroy function as well?

TIA,

  Nico
nico-amsterdam pushed a commit to nico-amsterdam/awesomplete that referenced this issue Apr 14, 2024
fixes issus LeaVerou#17252. a11y improvements. fix Talkback item sele…
cfa3ad7 
…ction. i18n for the status text.
nico-amsterdam pushed a commit to nico-amsterdam/awesomplete that referenced this issue Apr 16, 2024
fixes issues of LeaVerou#17252. a11y improvements. fix Talkback item …
beb8687 
…selection. i18n for the status text.
LeaVerou pushed a commit that referenced this issue Apr 19, 2024
@nico-amsterdam
fixes issues of #17252. a11y improvements. fix Talkback item selectio…
3c7ee84 
…n. i18n for the status text. (#17254)

* fixes issus #17252. a11y improvements. fix Talkback item selection. i18n for the status text.

* fixes issues of #17252. a11y improvements. fix Talkback item selection. i18n for the status text.

---------

Co-authored-by: Nico <[email protected]@users.noreply.github.com>
@nico-amsterdam
Copy link
Contributor Author

PR is merged, so this ticket can be closed.
Thanks

LeaVerou pushed a commit that referenced this issue Jul 25, 2024
@nico-amsterdam
Fixes issues of #17255. Fix tab sequence (#17256)
96cddba 
* fixes issus #17252. a11y improvements. fix Talkback item selection. i18n for the status text.

* fixes issues of #17252. a11y improvements. fix Talkback item selection. i18n for the status text.

* Make aria-activedescendant empty when none is selected. see w3c/aria#501 (comment)

* Make aria-activedescendant empty when none is selected. see w3c/aria#501 (comment)

* Transformation must end with visibility hidden. Fixes tab navigation to hidden li item

* Also in css leading tab characters. After css transition everything in the suggestion list must be hidden and for example links in suggestions should not be in the tab sequence anymore

* Fixes issue of #17255. Tab navigation when suggestions are shown is wrong

---------

Co-authored-by: Nico <[email protected]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nico-amsterdam