fixes issues of #17252. a11y improvements. fix Talkback item selection. i18n for the status text. #17254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nico-amsterdam
commented
Apr 17, 2024
nico-amsterdam
commented
- add tabindex to fix the issue that it is not possible to select an item when using the Talkback screen reader
- removed the screen reader text that is not used by Voiceover and Talkback, and superfluous for NVDA and Narrator
- new config options to pass on a different text for the status used for screen readers, enabling the possibility to supply a text in a different language
- update package.json to fix gulp
- fix leading tab characters in the source code (although personally I prefer all spaces)
- update tests
- update minimized version of awesomplete
added 3 commits
April 14, 2024 12:16
…ction. i18n for the status text.
…selection. i18n for the status text.
LeaVerou
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.