Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues of #17255. Fix tab sequence #17256

Merged
merged 10 commits into from
Jul 25, 2024

Conversation

nico-amsterdam
Copy link
Contributor

awesomplete.js:

  • Use tabindex -1 instead of 0 to make elements focusable. This does not disturb the tab sequence. Tested with the Talkback screen reader.
  • Make aria-activedescendant empty when none is selected. This is when
    • none of the items has aria-selected=true
    • or the popup is closed

awesomplete.theme.css

  • After the transition of 0.3 seconds the visibility should be hidden. Prevents navigation to anything inside the now hidden popup.

awesomplete.css is updated by gulp because of the change in awesomplete.theme.css

@dpb-bah
Copy link

dpb-bah commented Jul 25, 2024

Confirmed this works. We've been using awesomplete for a while but it flags issues with AXE scans for Section 508 compliance. This PR resolves it.

@LeaVerou
Copy link
Owner

Thanks for checking it out @dpb-bah and for contributing @nico-amsterdam!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants