Add istio dependency #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikenairn
force-pushed
the
add_istio_dependency
branch
2 times, most recently
from
e9ad6f7 to
63d1722
Compare
eguzki
reviewed
Feb 2, 2022
| - --upstream=http://127.0.0.1:8080/ | ||
| - --logtostderr=true | ||
| - --v=10 | ||
| image: gcr.io/kubebuilder/kube-rbac-proxy:v0.8.0 |
There was a problem hiding this comment.
I would remove the rbac proxy from the deployment. Maybe in other PR.
We removed it from the 3scale operator 3scale/3scale-operator#692
3scale Ops team has also removed the rbac proxy from their operator 3scale-ops/prometheus-exporter-operator#26
Check out for the reasons in the PRs
There was a problem hiding this comment.
Created follow up JIRA for this https://issues.redhat.com/browse/KUADRANT-32
eguzki
approved these changes
Feb 2, 2022
Changes the default namespace from `kuadrant-operator-system` to `kuadrant-system`. The kuadrant controller is currently hard coded to use `kuadrant-system` when creating resources, so using it here ensures all kuadrant resources end up in the same ns. Will also make docs between the operator/controller/kuadrantcl repos more consistent.
Add istio makefile with targets to help install/uninstall istio using istoctl. The default is to install it in it's own namespace `istio-system` since this is more likely how it will be deployed in a real world scenario. The install is also using the `default` profile which installs an ingress controller into the istio namespace `istio-ingressgateway`. Any example port-forward commands need to point to this ingress service: ``` kubectl port-forward -n istio-system service/istio-ingressgateway 9080:80 ``` A temporary patch for the istio install and make targets to configure a hard coded kuadrant/authorino setup for dev/test purposes is also added. These are triggered using seperate make targets `istio-install-with-patch` and `post-deploy-hacks` and will be removed once the operator itself has taken over the responsibility of creating/configuring these resources.
mikenairn
force-pushed
the
add_istio_dependency
branch
from
63d1722 to
ed446ea
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update namespace to kuadrant-system
Changes the default namespace from
kuadrant-operator-systemtokuadrant-system. The kuadrant controller is currently hard coded to usekuadrant-systemwhen creating resources, so using it here ensures all kuadrant resources end up in the same ns. Will also make docs between the operator/controller/kuadrantcl repos more consistent.Add istio make commands
Add istio makefile with targets to help install/uninstall istio using istoctl. The default is to install it in it's own namespace
istio-systemsince this is more likely how it will be deployed in a real world scenario. The install is also using thedefaultprofile which installs an ingress controller into the istio namespaceistio-ingressgateway. Any example port-forward commands need to point to this ingress service:A temporary patch for the istio install and make targets to configure a hard coded kuadrant/authorino setup for dev/test purposes is also added. These are triggered using seperate make targets
istio-install-with-patchandpost-deploy-hacksand will be removed once the operator itself has taken over the responsibility of creating/configuring these resources.Verification
Deploy no OLM:
or
Deploy with OLM:
Check deployment:
Note: If you deployed via OLM there will be some additional deployments/pods in the kuadrant-system ns not listed here.