remove kube-rbac-proxy sidecar

[eguzki]

What

Remove the kube-rbac-proxy container from the controller-manager

Kuadrant/kuadrant-operator#7 (comment)

Why

See:

https://github.com/3scale/3scale-operator/pull/692
https://github.com/3scale-ops/prometheus-exporter-operator/pull/26

Verification steps

• deploy limitador locally

make local-setup

• Expose metrics service locally

kubectl port-forward --namespace limitador-operator-system service/limitador-operator-controller-manager-metrics-service 8080:8080

• No need to add RBAC access token

$ curl http://127.0.0.1:8080/metrics
# HELP controller_runtime_active_workers Number of currently used workers per controller
# TYPE controller_runtime_active_workers gauge
controller_runtime_active_workers{controller="limitador"} 0
# HELP controller_runtime_max_concurrent_reconciles Maximum number of concurrent reconciles per controller
# TYPE controller_runtime_max_concurrent_reconciles gauge
controller_runtime_max_concurrent_reconciles{controller="limitador"} 1
# HELP controller_runtime_reconcile_errors_total Total number of reconciliation errors per controller
# TYPE controller_runtime_reconcile_errors_total counter
controller_runtime_reconcile_errors_total{controller="limitador"} 0
....

[didierofrivia]

👍🏼