Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove kube-rbac-proxy sidecar #33

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Conversation

eguzki
Copy link
Contributor

@eguzki eguzki commented Aug 16, 2022

What

Remove the kube-rbac-proxy container

#7 (comment)

Why

See:

Verification steps

make kind-create-cluster
make deploy
kubectl port-forward --namespace kuadrant-system service/kuadrant-operator-controller-manager-metrics-service 8080:8080

No need to add RBAC access token

$ curl http://127.0.0.1:8080/metrics
# HELP controller_runtime_active_workers Number of currently used workers per controller
# TYPE controller_runtime_active_workers gauge
controller_runtime_active_workers{controller="kuadrant"} 0
....

@eguzki eguzki requested a review from a team August 16, 2022 12:45
@eguzki eguzki marked this pull request as ready for review August 16, 2022 12:46
@eguzki eguzki requested a review from didierofrivia August 19, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants