use correct status type when enforcing policy

[maksymvavilov]

Now Enforced will be false even on partially enforced records. If there are no ready records it will still say "partially enforced" (which implies it is enforced on some of them which is not true). This will be addressed in #586
Adding a check to one of the tests to ensure we are not marking policy as Enforced - True when the record is not ready.

Aslo a tinny refactor - moved some vars around for convenience

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.60%. Comparing base (ece13e8) to head (e2bbd68).
Report is 97 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #594      +/-   ##
==========================================
+ Coverage   80.20%   82.60%   +2.39%     
==========================================
  Files          64       72       +8     
  Lines        4492     5416     +924     
==========================================
+ Hits         3603     4474     +871     
- Misses        600      634      +34     
- Partials      289      308      +19     

Flag	Coverage Δ
integration	73.96% <100.00%> (+2.67%)	⬆️
unit	33.75% <50.00%> (+3.71%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
api/v1beta1 (u)	71.42% <ø> (ø)
api/v1beta2 (u)	93.58% <100.00%> (+2.16%)	⬆️
pkg/common (u)	83.78% <ø> (-5.05%)	⬇️
pkg/istio (u)	75.86% <ø> (+1.94%)	⬆️
pkg/log (u)	94.73% <ø> (ø)
pkg/reconcilers (u)	∅ <ø> (∅)
pkg/rlptools (u)	79.84% <ø> (+0.39%)	⬆️
controllers (i)	80.83% <82.81%> (+4.03%)	⬆️

Files	Coverage Δ
controllers/dnspolicy_status.go	84.50% <100.00%> (-1.86%)	⬇️
...library/kuadrant/apimachinery_status_conditions.go	96.49% <100.00%> (+0.65%)	⬆️

... and 29 files with indirect coverage changes

[KevFan]

Changes looks good to me 👍

[guicassolato]

This is incorrect and should be reverted