Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use correct status type when enforcing policy" #677

Closed
wants to merge 2 commits into from

Conversation

guicassolato
Copy link
Contributor

@guicassolato guicassolato commented May 29, 2024

Reverts #594

The Enforced status of policies that are partially enforced should be True, not False.

@guicassolato guicassolato requested a review from a team as a code owner May 29, 2024 11:15
Copy link

codecov bot commented May 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.82%. Comparing base (ece13e8) to head (e3bafe1).
Report is 105 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #677      +/-   ##
==========================================
+ Coverage   80.20%   82.82%   +2.61%     
==========================================
  Files          64       72       +8     
  Lines        4492     5414     +922     
==========================================
+ Hits         3603     4484     +881     
- Misses        600      626      +26     
- Partials      289      304      +15     
Flag Coverage Δ
integration 74.36% <50.00%> (+3.07%) ⬆️
unit 33.74% <50.00%> (+3.71%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
api/v1beta1 (u) 71.42% <ø> (ø)
api/v1beta2 (u) 93.58% <100.00%> (+2.16%) ⬆️
pkg/common (u) 83.78% <ø> (-5.05%) ⬇️
pkg/istio (u) 75.86% <ø> (+1.94%) ⬆️
pkg/log (u) 100.00% <ø> (+5.26%) ⬆️
pkg/reconcilers (u) ∅ <ø> (∅)
pkg/rlptools (u) 79.84% <ø> (+0.39%) ⬆️
controllers (i) 81.17% <83.81%> (+4.37%) ⬆️
Files Coverage Δ
...library/kuadrant/apimachinery_status_conditions.go 96.36% <100.00%> (+0.53%) ⬆️
controllers/dnspolicy_status.go 85.91% <0.00%> (-0.45%) ⬇️

... and 32 files with indirect coverage changes

@mikenairn
Copy link
Member

This will need removed https://github.com/Kuadrant/kuadrant-operator/pull/655/files#diff-8ca7bb2b5ec65645cb6668b37f1e07e74cb4fdbc880ded9b176b34303da44b3cR134-R146, @makslion fyi

@guicassolato
Copy link
Contributor Author

guicassolato commented May 30, 2024

Superseded by #679

@maksymvavilov maksymvavilov deleted the revert-594-enforced_status branch May 30, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants