Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNSPolicy Enforced condition is not updated #611

Closed
ficap opened this issue May 3, 2024 · 2 comments · Fixed by #594
Closed

DNSPolicy Enforced condition is not updated #611

ficap opened this issue May 3, 2024 · 2 comments · Fixed by #594
Assignees
Labels
kind/bug Something isn't working

Comments

@ficap
Copy link

ficap commented May 3, 2024

When there is error in dnsrecord of dnspolicy, Enforced status is not updated to Enforced=false in dnspolicy's status. the status looks like this:

      conditions:
        - lastTransitionTime: '2024-05-03T10:37:03Z'
          message: DNSPolicy has been accepted
          reason: Accepted
          status: 'True'
          type: Accepted
        - lastTransitionTime: '2024-05-03T10:37:03Z'
          message: DNSPolicy has been successfully enforced
          reason: Enforced
          status: 'True'
          type: Enforced
      observedGeneration: 1
      recordConditions:
        backend.ficap.example.com:
          - lastTransitionTime: '2024-05-03T10:52:12Z'
            message: 'The DNS provider failed to ensure the record: failed to submit
              all changes for the following zones: [/hostedzone/ZONEID]'
            observedGeneration: 1
            reason: ProviderError
            status: 'False'
            type: Ready

Depending on the meaning of enforced condition it should be updated properly.

@ficap ficap added this to Kuadrant May 3, 2024
@ficap ficap changed the title DNSPolicy Enforce condition is not updated DNSPolicy Enforced condition is not updated May 3, 2024
@pehala pehala added the kind/bug Something isn't working label May 7, 2024
@philbrookes philbrookes moved this to Ready For Review in Kuadrant May 9, 2024
@maksymvavilov maksymvavilov self-assigned this May 9, 2024
@maksymvavilov maksymvavilov linked a pull request May 9, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant May 23, 2024
@maksymvavilov
Copy link
Contributor

Reopened - if partially enforced we should report it as ready

@maksymvavilov
Copy link
Contributor

closed with #679

@github-project-automation github-project-automation bot moved this from In Progress to Done in Kuadrant May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants