layers: Fix PIPELINE_STATE::GetStageStates bug #4760
Conversation
spencer-lunarg
requested review from
ncesario-lunarg,
arno-lunarg and
juan-lunarg
|
CI Vulkan-ValidationLayers build queued with queue ID 28432. |
|
CI Vulkan-ValidationLayers build # 9324 running. |
|
CI Vulkan-ValidationLayers build # 9324 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 28459. |
| self.flag_values_definitions[flag] = Guarded(self.featureExtraProtect, decl) | ||
| if flag in self.flagBitsAsArray: | ||
| decl = 'const std::array<%s, %d> All%s = {%s};' % (flag, len(bits), flag, ','.join(bits)) |
There was a problem hiding this comment.
Nit: maybe use formatted string literals instead (not 100% sure about the syntax):
decl = 'const std::array<{flag}, {len(bits)}> All{flag} = {{{','.join(bits)}}}'There was a problem hiding this comment.
So yes, the python string format debate 😆
I have zero preference how we printf in the scripts, but as long as it is consistent everywhere... which is far from currently. I just mimicked the styles in the function above and where the other std::array string is
There is a long needed TODO to align all these to a single style
|
CI Vulkan-ValidationLayers build # 9326 running. |
|
CI Vulkan-ValidationLayers build # 9326 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 28800. |
|
CI Vulkan-ValidationLayers build # 9344 running. |
|
CI Vulkan-ValidationLayers build # 9344 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 28994. |
|
CI Vulkan-ValidationLayers build # 9347 running. |
|
CI Vulkan-ValidationLayers build # 9347 failed. |
|
CI Vulkan-ValidationLayers build queued with queue ID 29032. |
|
CI Vulkan-ValidationLayers build # 9349 running. |
|
CI Vulkan-ValidationLayers build # 9349 passed. |
closes #4689
Better version of #4690