layers: Fix PIPELINE_STATE::GetStageStates bug #4690
Conversation
|
CI Vulkan-ValidationLayers build queued with queue ID 18082. |
|
CI Vulkan-ValidationLayers build # 9125 running. |
|
CI Vulkan-ValidationLayers build # 9125 passed. |
| // (1 << 31) is greater than VK_SHADER_STAGE_FLAG_BITS_MAX_ENUM | ||
| for (uint32_t stage_idx = 0; stage_idx < 31; ++stage_idx) { |
There was a problem hiding this comment.
Does this actually fix the original issue? I'm not sure I see what changed here. I would think we would need something like stage_idx = highest_bit(VK_SHADER_STAGE_FLAG_BITS_MAX_ENUM); to make UBSAN happy here, but I'm probably missing something.
There was a problem hiding this comment.
So this code logic needs to loop through all the VkShaderStageFlagBits values
VK_SHADER_STAGE_FLAG_BITS_MAX_ENUM == 0x7FFFFFFF
so I assumed the 1 << 30 is 0x40000000 which is the max any valid Vulkan FlagBits can be. I assume this change would correctly fix UBSAN, but honestly I would rather have a way to loop through all the VkShaderStageFlagBits, I was thinking how we have these vectors in paramater_validation.cpp such as const std::vector<VkFormat> AllVkFormatEnums and that maybe it would be smarter to just generate something similar for this code instead
rationale behind the rename
I didn't know what Vec stood for, wasn't an intuitive abbreviation for me, but now realizing we use *Vec else where, rather not inconsistently change it here
There was a problem hiding this comment.
Ah, I completely missed the 32 -> 31. I'm good with this if it fixes the original issue. The comment wasn't intuitive to me the first time I read it, but I probably just read it too quickly.
There was a problem hiding this comment.
the fact you can't at a glance know if it is correct or not is the problem IMO, going to just generate an array to loop through stages flags
|
closing for a better solution I will create |
closes #4689