build: Update known-good files for 1.2.144 header [WIP] #1952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shannon-lunarg
force-pushed
the
shannon-144-known-good-update
branch
5 times, most recently
from
87edbe2 to
f13e417
Compare
Changes: - Updated known-good files - Modified `vk_validation_stats.py` to handle new latex expressions - Generated new source files using `generate_source.py` Change-Id: Icc9016c69ef60c84f96cd3ffa33971dcb43c6a2b
Change-Id: Ica4fc36686d702ea3b61c5a6e9bdda7c380a31f7
VUID-VkBufferMemoryBarrier-buffer-01763 was replaced by VUID-VkBufferMemoryBarrier-buffer-04088 and VUID-VkImageMemoryBarrier-image-01766 was replaced by VUID-VkImageMemoryBarrier-image-04071 Change-Id: I21520999592e6459a14bf62c5b24c871f12008cc
shannon-lunarg
force-pushed
the
shannon-144-known-good-update
branch
from
f13e417 to
9872717
Compare
VUID-VkPipelineViewportShadingRateImageStateCreateInfoNV-pDynamicStates- 02057 was replaced by VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04057 and VUID-VkPipelineViewportExclusiveScissorStateCreateInfoNV-pDynamicStates- 02030 was replaced by VUID-VkGraphicsPipelineCreateInfo-pDynamicStates-04056 Change-Id: I64791311233a570ec69848587eb419cc69285168
Change-Id: I2d2bb7dfc4da6310f1af452835cb0165e1b20efa
VUID-VkBufferMemoryBarrier-buffer-01764 and VUID-VkBufferMemoryBarrier-buffer-01765 were combined into VUID-VkBufferMemoryBarrier-buffer-04089 and VUID-VkImageMemoryBarrier-image-01767 and VUID-VkImageMemoryBarrier-image-01768 were combined into VUID-VkImageMemoryBarrier-image-04072 Change-Id: I83c3fd471a98658e75d23230b24fb6b9256a13dc
VUID-VkBufferMemoryBarrier-buffer-01192 corresponds to VUID-VkBufferMemoryBarrier-buffer-04086 and VUID-VkImageMemoryBarrier-image-01200 corresponds to VUID-VkImageMemoryBarrier-image-04069 Change-Id: I78f57074252255d7ca0e0fa9a9e3100d534dd541
VUID-VkBufferMemoryBarrier-buffer-01193 and VUID-VkImageMemoryBarrier-image-01201 were removed Change-Id: Icb739d96e45dd3dc7cdbadef9638ad518257cdf8
shannon-lunarg
force-pushed
the
shannon-144-known-good-update
branch
from
9872717 to
b4f041b
Compare
VUID-VkImageMemoryBarrier-image-01205 and
VUID-VkBufferMemoryBarrier-buffer-01196 were removed but their
requirements remain in the spec. These were replaced by
UNASSIGNED-CoreValidation-vkImageMemoryBarrier-sharing-mode-exclusive-
same-family and
UNASSIGNED-CoreValidation-vkBufferMemoryBarrier-sharing-mode-exclusive
same-family
Change-Id: I50fcf7fa344804179ffa9b651535212435179f2d
|
Info: Vulkan-Tools codegen was blocking the 144 update over the weekend. The mock_icd codegen needed to be updated for this PR to pass GitHub CI. Updating the codegen in Vulkan-Tools did not work as expected with vulkaninfo (the fix for this can be found here). Either this PR or the 145 known-good PR should be up for review before the end of the day. |
VUID-VkSamplerYcbcrConversionCreateInfo-format-01649 now corresponds with VUID-VkSamplerYcbcrConversionCreateInfo-format-04060 Change-Id: I09a1bbb77db9ba1b2f540b7bbc4ade2e6a942477
|
Superseded by the 145 header update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
vk_validation_stats.pyto handle new latex expressionsgenerate_source.pyThere are 10 more VUID inconsistencies I still need to address, I'm working through them now. Final commits should be added shortly.
This branch still needs to undergo internal testing and clang format checks.
Work from #1926 has been incorporated into this PR so it will be closed.