Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing validation for VkExternalMemoryImageCreateInfo with valid externalFormat #1934

Closed
courtney-g opened this issue Jun 11, 2020 · 5 comments · Fixed by #1985
Closed

Missing validation for VkExternalMemoryImageCreateInfo with valid externalFormat #1934

courtney-g opened this issue Jun 11, 2020 · 5 comments · Fixed by #1985
Assignees
@sfricke-samsung
Milestone
sdk-1.2.148.0

Comments

@courtney-g
Copy link
Contributor

While adding support to ANGLE for importing external images I ran into validation errors that I don't think are errors.

In particular, I was getting complaints about an invalid VkFormat of VK_FORMAT_UNDEFINED. While it's generally true that having a VkFormat of VK_FORMAT_UNDEFINED is not valid, there are cases when using the VK_KHR_external_memory extension where it's required.
courtney-g added a commit to courtney-g/Vulkan-ValidationLayers that referenced this issue Jun 11, 2020
@courtney-g
Add support for VK_KHR_external_memory
40e10b6 
There are places where VK_KHR_external_memory extension requires that
a VkFormat be VK_FORMAT_UNDEFINED. This CL highlights some of those
cases but I doubt it is complete or of production quality at this time.

Issue: KhronosGroup#1934
Change-Id: I140e5b63cd85acee2697454920e1bd5c10f46d77
@courtney-g
Copy link
Contributor Author

Reference CL can be found here: courtney-g@40e10b6

That's not final or complete, just what I changed to get validation happy. I'll leave it to LunarG to provide production code.

@sfricke-samsung
Copy link
Contributor

So this was an issue I already have caught and made the internal spec fixes a few weeks ago, but the change is in the 1.x.143 headers which are currently being pulled in (also left a comment explaining this exact issue yesterday)

So if you don't mind waiting, once the #1926 gets pulled in, I have a change to fix the whole VK_FORMAT_UNDEFINED format issue here!

@courtney-g
Copy link
Contributor Author

Awesome, that sounds great!

@mark-lunarg
Copy link
Contributor

@spencer, I'm hoping this is unblocked now, yes?

@sfricke-samsung
Copy link
Contributor

no, waiting on #1952 to merge now since #1926 worked moved there

@sfricke-samsung sfricke-samsung mentioned this issue Jun 29, 2020
Merged
@shannon-lunarg shannon-lunarg added this to the sdk-1.2.148.0 milestone Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sfricke-samsung sfricke-samsung

Labels
None yet
Projects
None yet
Milestone
sdk-1.2.148.0
Development

Successfully merging a pull request may close this issue.

layers: Fix YCbCr Format VUIDs sfricke-samsung/Vulkan-ValidationLayers
4 participants
@courtney-g @mark-lunarg @shannon-lunarg @sfricke-samsung