Implement phase one of the migration to group attributes #343
Conversation
Perksey
changed the title
|
This is ready for review. |
There was a problem hiding this comment.
Yeah, double-checked this. The schema won't validate gl.xml both because the group tags were removed from the schema, and the group attribute is required but not present on all enum tags. I think it would be best to make the enum attribute optional as it's unlikely all of them will belong to a group - of course it could be forced but that could end up with a lot of verbosity and unused group names.
|
@pdaniell-nv I think this is OK to merge per #335, let me know when WG signs off. Also see #346. |
|
I'll put this on the agenda for the next OpenGL/ES WG meeting January 22nd. If that is too far out let me know and I'll call an email vote. |
|
January 22nd is good for me, I look forward to getting this signed off.
…On Mon, 13 Jan 2020 at 23:24, Piers Daniell ***@***.***> wrote:
I'll put this on the agenda for the next OpenGL/ES WG meeting January
22nd. If that is too far out let me know and I'll call an email vote.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#343?email_source=notifications&email_token=ACVEYI7FCUTL2SA6CWWWRC3Q5TZ4RA5CNFSM4KEMCBU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI2VYLQ#issuecomment-573922350>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACVEYIYB62MFPED5WQJD2K3Q5TZ4RANCNFSM4KEMCBUQ>
.
|
|
Approved to merge. Thanks for your patience. |
The commit after that changes the schema, see: KhronosGroup/OpenGL-Registry#335 KhronosGroup/OpenGL-Registry#343 To follow these changes, we will need to massage the registry processor accordingly, but this will be done later.
This was inserted in #343, probably as an accidental side-effect of someone's editor - it is not mentioned in the PR comments - and is breaking some downstream scripts which consume the file.
|
@Perksey a stray BOM crept into gl.xml in this PR which the vk-gl-cts project just got affected by. Propose to pull it out in #506. I assume this was an accident as it's not mentioned anywhere in the comments above but in any event, the file is defined to be encoded in UTF-8. Probably the Python script should be tweaked to open the registry in UTF-8 mode, although it just contains ASCII. |
Implements the new schema from #335 and deprecates the old one. That issue should be kept open until the Khronos Group decides to remove the old group blocks permenantly.
The enumerants have been tagged using an automated process. As such, the groups will have been preserved in this new format exactly as they were in the old format.
The RNC schema has also been updated.