Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove BOM from gl.xml #506

Merged
merged 1 commit into from
May 11, 2022
Merged

Remove BOM from gl.xml #506

merged 1 commit into from
May 11, 2022

Conversation

oddhack
Copy link
Collaborator

@oddhack oddhack commented May 11, 2022

This was inserted in #343, probably as an accidental side-effect of
someone's editor - it is not mentioned in the PR comments - and is
breaking downstream scripts in vk-gl-cts which consume the file. The file encoding is defined to be UTF-8 in any event.

This was inserted in #343, probably as an accidental side-effect of
someone's editor - it is not mentioned in the PR comments - and is
breaking some downstream scripts which consume the file.
Copy link
Contributor

@Perksey Perksey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for this, looks like the C# application we used to automate the migration to group attributes introduces a BOM by default. Not having this won't break us so should be fine.

@oddhack oddhack merged commit b064336 into main May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants