Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gl.xml] non-parsable groups "DataType" and "FfdMaskSGIX" #351

Closed
SunSerega opened this issue Jan 19, 2020 · 2 comments
Closed

[gl.xml] non-parsable groups "DataType" and "FfdMaskSGIX" #351

SunSerega opened this issue Jan 19, 2020 · 2 comments

Comments

@SunSerega
Copy link
Contributor

  1. Line 1017:

    		<group name="DataType" comment="See enums block below"/>
    

    There isn't anything in enums tag, refering to this, but on line 240:

    		<group name="DataTypeEXT">
    			<enum name="GL_SCALAR_EXT"/>
    			<enum name="GL_VECTOR_EXT"/>
    			<enum name="GL_MATRIX_EXT"/>
    		</group>
    
  2. Line 1264:

    		<group name="FfdMaskSGIX" comment="See enums section below. Was SGIXFfdMask"/>
    

    This time there are enums refering to this, on line 5137:

    	<enums namespace="GL" group="FfdMaskSGIX" type="bitmask">
    		<enum value="0x00000001" name="GL_TEXTURE_DEFORMATION_BIT_SGIX"/>
    		<enum value="0x00000002" name="GL_GEOMETRY_DEFORMATION_BIT_SGIX"/>
    	</enums>
    

Still, in both cases comments are used, which aren't parsable.

I guess DataType group should be removed, as it isn't used anywhere (instead all commands use DataTypeEXT).
And FfdMaskSGIX should be properly filled.

@Perksey
Copy link
Contributor

Perksey commented Jan 19, 2020

The group blocks are deprecated in favour of group attributes as described in #335 and #343. Please check if your issue is still present with the new schema. If the PR fixes your issue, please close it.

@SunSerega
Copy link
Contributor Author

SunSerega commented Jan 20, 2020

I've seen issue, but not pull before posting...
I'll close this when/if pull get's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants