Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AllowedMentions #66

Merged
merged 23 commits into from
Mar 19, 2020
Merged

feat: AllowedMentions #66

merged 23 commits into from
Mar 19, 2020

Conversation

Khaaz
Copy link
Owner

@Khaaz Khaaz commented Mar 8, 2020

PULL REQUEST

Overview

This PR adds support for AllowedMentions to AxonCore. discord/discord-api-docs#1396
It documents it and if needed adds support for it. This doesn't remove disableEveryone for now and will keep the two side by side.
This is meant to evolve as this PR is updated.

WIP: Standby for actual merge in djs and eris.
eris: abalabahaha/eris#649
djs: discordjs/discord.js#3893

Status

  • Typings have been updated or don't need to be.
  • This PR have been tested and is ready to be merged.

Semantic versioning classification

  • This PR introduces BREAKING changes.
  • This PR adds new features, improve the code and implies minimal changes.
  • This PR fixes a bug and references the relevant issue or documentation.
  • This PR improve performance or code refactor without API changes.
  • This PR only includes non-code changes (documentation, CI, tools...).

@Khaaz
Copy link
Owner Author

Khaaz commented Mar 19, 2020

This has been merged in both djs and eris, merging as well.

src/Core/Base.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
Khaaz and others added 2 commits March 19, 2020 13:29
src/Utility/AxonUtils.js Outdated Show resolved Hide resolved
src/Utility/AxonUtils.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
src/Utility/AxonUtils.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
src/Core/Base.js Outdated Show resolved Hide resolved
src/Utility/AxonUtils.js Outdated Show resolved Hide resolved
bsian03 added a commit to bsian03/AxonCore that referenced this pull request Mar 19, 2020
@Khaaz Khaaz merged commit cb6b91a into dev Mar 19, 2020
@Khaaz Khaaz deleted the allowedmentions branch March 19, 2020 19:24
@Khaaz Khaaz mentioned this pull request Mar 19, 2020
7 tasks
Khaaz pushed a commit that referenced this pull request Mar 20, 2020
* Enum documentation fixes

* Lint types folder (soon)

* Split typings

* Codefactor

* Removed unnecessary overload. Try and link #58 to PR?

* Should fix CI

* Reflect correction in 27d7d9c

* Added library typings

* Add rest of typings

* Typo

* Finished rest of library typings, bug fixes etc

* Export file, bug fixes, typos etc

* Typings change

* Naming typos

* Attempt 2

* b85c399, 22610d8 and df13457 reflections

* b854f61 reflections

* b8f415f reflections

* 9139554 reflections

* 7631742 reflections

* b0563ac reflections

* 95c586c reflections and bug fixes from previous commit

* 6296f7c reflections

* 21b3014 reflections

* 21b3014 reflections

* 38d7b34 reflections

* Added WinstonLogger

* Lint

* Don't emit file outputs on tsc check

* Add updateDBVal type

* Changed name

* Add path references

* fix

* Fix the damn CI

* Correct path

* 37a4838 and previous reflections

* f0978c2 reflections

* #64 reflections

* Clear warnings from e69bf1c

* 3ff2100 reflections

* e5bcc33 reflections

* Confirmed typo

* #65 reflections

* Rename

* #67 reflections

* Remove unused imports

* Added Library selector postinstall script, needs testing

* Remove language check/selection

* Remove variable in global

* Constant

* Move to scripts folder

* Exit process if CI detected

* Add CI env vars

* #69 reflections

* Added name to dep install and test

* Consistency

* #72 reflections

* Add first and sweep methods

* Test something

* Fix pathing

* Trying something...

* module declaration?

* Fix typings

* Return `this` where appropriate

* Save json only if invalid config

* Bump events to 13.9.2

* #70 reflections

* #66 reflections

* 0af8a88 reflections

* #73 reflections

* 061de33 reflections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants