Implement Allowed Mentions #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skillz4Killz
suggested changes
Mar 4, 2020
Skillz4Killz
reviewed
Mar 4, 2020
Khaaz
approved these changes
Mar 4, 2020
There was a problem hiding this comment.
Looking good! That's also how I would have done it.
As this feature is due to a breaking change in Discord API I'm also inclined to entirely remove disableEveryone.
However if we want to still support legacy behavior, we could manually add "everyone" if they still pass disableEveryone and it is explicitely set to false.
I personally don't think we should do this as, at worst it will just suppress everyone mention for everyone and this feature looks like a big change in DAPI and can probably also be for users wanting to use last eris version.
|
Also, this ref discord/discord-api-docs#1396 |
7 tasks
abalabahaha
approved these changes
Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented Allowed Mentions. Since this functionality entirely covers the use cases of
disableEveryone, I replaced it entirely. Feedback and testing for this PR would be appreciated.