Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings/ci: Split typings #59

Merged
merged 85 commits into from
Mar 20, 2020
Merged

typings/ci: Split typings #59

merged 85 commits into from
Mar 20, 2020

Conversation

bsian03
Copy link
Contributor

@bsian03 bsian03 commented Feb 20, 2020

PULL REQUEST

Overview

See #58

Status

  • Typings have been updated or don't need to be.
  • This PR have been tested and is ready to be merged.

Semantic versioning classification

  • This PR introduces BREAKING changes.
  • This PR adds new features, improve the code and implies minimal changes.
  • This PR fixes a bug and references the relevant issue or documentation.
  • This PR improve performance or code refactor without API changes.
  • This PR only includes non-code changes (documentation, CI, tools...).

@bsian03
Copy link
Contributor Author

bsian03 commented Feb 20, 2020

Trying to get #58 as a linked issue

@Khaaz Khaaz linked an issue Feb 20, 2020 that may be closed by this pull request
@Khaaz
Copy link
Owner

Khaaz commented Feb 20, 2020

I linked it manually, you need to use closing keyword (eg: closes, fixes, resolves etc)

@bsian03
Copy link
Contributor Author

bsian03 commented Feb 20, 2020

Makes sense. I have no idea how GH works :ded:

@Khaaz
Copy link
Owner

Khaaz commented Feb 20, 2020

API changes that needs to be reflected in the typings:

  • CommandPermissions(ADD(guildIDs)): b85c399 + docs(22610d8)
  • CommandPermissions(RENAME): df13457
    • user => author
    • userIDs => users
    • roleIDs => roles
    • channelIDs => channels
    • guildIDs => guilds
  • ADBProvider(async methods): e619447
    async all methods
  • InMemoryProvider(cleanup): b854f61
    remove some methods + async some methods
  • AxonClient(RENAME: infos => info): b8f415f
  • Module(RENAME: infos => info): 9139554
  • Command(RENAME: infos => info): 7631742
  • Listener(RENAME: infos => info): b0563ac
  • RENAME: Queue => FunctionQueue: 95c586c
  • GuildConfigs(RENAME): 6296f7c
    input is eventListeners and not listeners
  • ADD(Queue): 21b3014
  • ADD(Stack): 38d7b34

types/Loggers/SignaleLogger.ts Show resolved Hide resolved
types/Database/Mongo/AxonSchema.ts Show resolved Hide resolved
types/Database/Mongo/GuildSchema.ts Show resolved Hide resolved
types/Utility/External/LRUCache.ts Outdated Show resolved Hide resolved
@Khaaz
Copy link
Owner

Khaaz commented Feb 22, 2020

Referencing changes that needs to be applied to typings:
DJS(InviteCreate, InviteDelete): #62
DJS(MessageReactionRemoveEmoji + various naming changes): #63
Eris(InviteCreate, InviteDelete): #60
Eris(MessageReactionRemoveEmoji): #61

types/Loggers/LoggerSelector.ts Outdated Show resolved Hide resolved
@bsian03
Copy link
Contributor Author

bsian03 commented Feb 23, 2020

310e16a has the module exports working properly, wasn't what I thought I needed to do at all :P

scripts/typings.js Outdated Show resolved Hide resolved
@Khaaz
Copy link
Owner

Khaaz commented Mar 19, 2020

For the record, this PR also has updated typings changes for:
SortedList: #69
Stores: #72
allowedMentions: #66
VIEW_GUILD_INSIGHTS: #70
Subcommands: #73

@Khaaz
Copy link
Owner

Khaaz commented Mar 20, 2020

missingChannelPerms method in Utils: 061de33

Then I think we are good to merge. If you confirm that everything work as you expect on your side, we can merge and release!

@bsian03
Copy link
Contributor Author

bsian03 commented Mar 20, 2020

Finished

@Khaaz
Copy link
Owner

Khaaz commented Mar 20, 2020

Long awaited, this finish to bring TS support to the framework and introduce v2.
Thanks again Bsian for such an incredible work!

@Khaaz Khaaz merged commit 075d0fe into Khaaz:dev Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typings: File splitting
2 participants