This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(flows): New route button should use supportsMultipleFlows property #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apupier
previously approved these changes
Jun 29, 2023
There was a problem hiding this comment.
- Works fine for me locally.
- route ids not in sync between UI and source code but doubt it will be related to this PR, Ricardo is aware and will check
- Note that in fact Kaoto backend doesn't support multiple routes correctly currently for Integration Kind (contrarily to the attribute value claimed by the API), see [BUG] Integration CRD: Missing multiple route support kaoto-backend#733 and [BUG] Multiple Integrations generated cannot be executed by Camel Runtime kaoto-backend#726
Codecov Report
@@ Coverage Diff @@
## main #2064 +/- ##
==========================================
+ Coverage 65.05% 67.15% +2.09%
==========================================
Files 88 89 +1
Lines 2859 2886 +27
Branches 661 667 +6
==========================================
+ Hits 1860 1938 +78
+ Misses 953 902 -51
Partials 46 46
|
Currently, there's a `supportsMultipleFlows` property from the capabilities endpoint from the backend that the UI is not leveraging yet. This property is meant to signal the UI whether a DSL supports multiple flows or not. This pull request makes use of the said property to disable the New route button in case the UI is dealing with those kinds of DSL. At the moment of writing this code, those DSLs are `Kamelet` and `KameletBindings` fixes: #2055
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, there's a
supportsMultipleFlowsproperty from the capabilities endpoint from the backend that the UI is not leveraging yet.This property is meant to signal the UI whether a DSL supports multiple flows or not.
Changes
This pull request makes use of the said property to disable the New route button in case the UI is dealing with those kinds of DSL.
At the moment of writing this code, those DSLs are
KameletandKameletBindingsBefore
for Kamelet and KameletBindings, add new routes were allowed from the UI
After
Kamelet and KameletBindings options are disabled if a route of the same DSL already exists
fixes: #2055