This repository has been archived by the owner on Nov 27, 2023. It is now read-only.
fix(viz): Use metadata.name as flow identifier #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2059 +/- ##
==========================================
- Coverage 65.15% 65.05% -0.10%
==========================================
Files 88 88
Lines 2858 2859 +1
Branches 659 661 +2
==========================================
- Hits 1862 1860 -2
- Misses 949 953 +4
+ Partials 47 46 -1
|
lordrip
commented
Jun 27, 2023
| @@ -18,11 +18,10 @@ Cypress.Commands.add('openCodeEditor', () => { | |||
| }); | |||
|
|
|||
| Cypress.Commands.add('editorAddText', (line, text) => { | |||
| const arr = text.split('\n'); | |||
There was a problem hiding this comment.
Hi @unsortedhashsets, I updated these lines, but if it was like that for a reason that maybe I'm not aware of, I'll be happy to revert the file.
Currently, the UI creates the flows IDs in two places: 1. Upon syncing the code through the useFlowsStore.setFlowsWrapper() method 2. Upon creating a new flow when using the New Flow button For the .1, since the UI doesn't have a previous ID because we're starting from the source code, the UI creates an ID using the DSL name and the position index, i.e. "Camel Route-1". For the .2, the UI uses a service to generate an ID with the word "route-####" while "####" it's a 4 digits random number. In this commit, the UI leverages the IFlowsWrapper.flows[0].metadata.name property as an ID for each flow, this way, whenever a sync happens, the IDs will be the same. fixes: KaotoIO/vscode-kaoto#280 fixes: #1910
|
Kudos, SonarCloud Quality Gate passed!
|
apupier
reviewed
Jun 28, 2023
This won't be a problem after #2064 as the Ui will prevent creating several routes for Kamelet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Currently, the UI creates the flows IDs in two places:
For the .1, since the UI doesn't have a previous ID because we're starting from the source code, the UI creates an ID using the DSL name and the position index, i.e. "Camel Route-1".
For the .2, the UI uses a service to generate an ID with the word "route-####" while "####" it's a 4 digits random number.
Changes
In this commit, the UI leverages the IFlowsWrapper.flows[0].metadata.name property as an ID for each flow, this way, whenever a sync happens, the IDs will be the same.
fixes: KaotoIO/vscode-kaoto#280
fixes: #1910