Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

"New route" button should not add multiple CRDs #2055

Closed
igarashitm opened this issue Jun 27, 2023 · 0 comments · Fixed by #2064
Closed

"New route" button should not add multiple CRDs #2055

igarashitm opened this issue Jun 27, 2023 · 0 comments · Fixed by #2064
Assignees
@lordrip
Labels
bug Something isn't working
Milestone
1.1.0

Comments

@igarashitm
Copy link
Contributor

Describe the Bug

Currently the "New route" button adds multiple CRDs for Integration, Kamelet and KameletBinding. Since multiple CRDs require bigger consideration for having multiple contexts, we decided to

  • Integration kind: Add routes in the existing CRD
  • Kamelet kind: Disable New route
  • KameletBinding: Disable New route

Until we fully support multiple contexts.

Steps to Reproduce the Bug or Issue

  1. Choose Integration, Kamelet or KameletBinding
  2. Click New route button

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@igarashitm igarashitm added the bug Something isn't working label Jun 27, 2023
@igarashitm igarashitm added this to the 1.1.0 milestone Jun 27, 2023
This was referenced Jun 27, 2023
Closed
Closed
@lordrip lordrip self-assigned this Jun 28, 2023
@lordrip lordrip mentioned this issue Jun 28, 2023
Merged
lordrip added a commit that referenced this issue Jun 29, 2023
@lordrip
fix(flows): New route button should use supportsMultipleFlows property
b05de66 
Currently, there's a `supportsMultipleFlows` property from the capabilities
endpoint from the backend that the UI is not leveraging yet.

This property is meant to signal the UI whether a DSL supports multiple
flows or not.

This pull request makes use of the said property to disable the
New route button in case the UI is dealing with those kinds of DSL.

At the moment of writing this code, those DSLs are `Kamelet` and `KameletBindings`

fixes: #2055
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lordrip lordrip

Labels
bug Something isn't working
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

fix(flows): New route button should use supportsMultipleFlows property
2 participants
@igarashitm @lordrip