Migrate alpha to beta again #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`spacedock.target` is not directly used on our servers, instead an edited copy exists in `/etc/systemd/system/`. See #258 for more information. The `README.md` has been updated to reflect newer versions of Python and other dependencies in use. The `api.md` has also been extended a little.
pystache is not Python3.8 compatible. Chevron is the continuation of it.
This commit adds the ability for admins to lock mods. When locking mods, they will automatically be unpublished and as such are no longer visible to other users besides the author. When locking mods, admins can leave a message up to 1024 chars. This message is shown to the author in place of the publish button. Admins can (un)lock mods via a new button in the "Author Tools" section, only shown to them. After unlocking the mod stays unpublished. The author or admin has to manually publish it again. While the mod is locked, the author can still do everything he could do before with the mod, with the sole exception of publishing it. This means updating, deleting versions, editing the description and so on is available, and might even be necessary to get the cause of the lock resolved. Locking is done via the new route `/mod/mod_id/lock`(a), unlocking via `/mod/mod_id/unlock`. They get the reason from the form, set `mod.published` to `False` respective `True`, and mod.locked to the contrary value. A `notify_ckan()` is issued with the event type `locked` and `unlocked`. Then they return a redirect to the mod page. `mods.publish()` now checks `mod.locked` before publishing the mod. If it is locked, a 403 is returned. The lock status is saved in `Mod.locked` (a bool, defaulting to `False` obviously), the lock reason message in `Mod.lock_reason`, a 1024-char unicode string. The locking admin is saved in `Mod.locked_by`.
Renames the .follow-button class to .follow-mod-button (and .unfollow-button to .unfollow-mod-button to stay consistent). Several times users reported missing download or follow buttons. While I can't confirm it for the download button, I can reproduce it for the follow button thanks to a user reporting it together with the ad-blocker they are using. It seems to be the "Block Tracking through Social-Media-Symbols" option in Adblock Plus. It is based on the "Fanboy's Social Blocking List", which includes the filter ##.follow-button . Renaming the class to .follow-mod-button resolves the problem.
Rename .follow-button class to workaround over-eager adblockers
HebaruSan
added
Type: Bug
Type: Improvement
Area: Backend
|
The "Merge branch 'beta' into alpha" commit was to resolve a phantom "conflict" that GitHub was showing in |
* Don't restart containers in~ development setup * Show short mod abstract below title; Add .vertical-centered css class The new CSS class is used for the short mod abstract.
* Remove old links from navbar dropdown menu * Remove spacedock-notify systemd remnants
* Fix default game fallback in _restore_game_info * Don't default to KSP at mod creation
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supposedly there's a production upgrade coming up in June to celebrate the release of Ubuntu 20.04. There are a couple of changes in alpha now that it would be nice to have ready for that (one of which is holding up KSP-CKAN/CKAN#3059), so this PR advances them to beta.
Included feature PRs:
Included fix PRs: